Add toggle for dark mode, using local storage #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holly-cummins
force-pushed
the
dark-mode-toggle
branch
4 times, most recently
from
cbd8c19 to
1e2062a
Compare
holly-cummins
force-pushed
the
dark-mode-toggle
branch
from
1e2062a to
8ddca6a
Compare
|
🙈 The PR is closed and the preview is expired. |
|
Since the parent site now has this toggle, and the preview looks ok, merging. I can't fully test the local storage is synchronized between the parent site and this site except on the live site. I've also got a FOUC on the dark mode load, but I think the solution there is to address some of the broader performance and site loading issues (https://github.com/quarkusio/extensions/issues?q=is%3Aopen+is%3Aissue+label%3Aperformance). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirror of quarkusio/quarkusio.github.io#1962