Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dissable the testHttp10WithoutHostHeader on openshift #2237

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Dec 3, 2024

Summary

The test needs to be disabled on openshift as for comunication outside, the valid 'Host' header needs to be set. This not need to be set when the request and endpoint is running on same machine.

This is followup of #2215 where I miss that HeadersIt also run on openshift so I dind't check it.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97
Copy link
Member Author

jedla97 commented Dec 3, 2024

run tests

The test needs to be disabled on openshift as for comunication outside the valid
'Host' header needs to be set
@jedla97 jedla97 force-pushed the fix-testHttp10WithoutHostHeader-on-ocp branch from cb4cf0c to 73d8cf1 Compare December 11, 2024 12:56
@jedla97
Copy link
Member Author

jedla97 commented Dec 11, 2024

run tests

1 similar comment
@jedla97
Copy link
Member Author

jedla97 commented Dec 11, 2024

run tests

@jedla97 jedla97 force-pushed the fix-testHttp10WithoutHostHeader-on-ocp branch from 4f9ad70 to 73d8cf1 Compare December 11, 2024 14:33
@jedla97
Copy link
Member Author

jedla97 commented Dec 11, 2024

run tests

@jedla97 jedla97 force-pushed the fix-testHttp10WithoutHostHeader-on-ocp branch from fa17fd1 to 73d8cf1 Compare December 11, 2024 15:50
@jedla97
Copy link
Member Author

jedla97 commented Dec 12, 2024

run tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant