-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinecone embedding store #64
Conversation
e22238f
to
fca573b
Compare
CI seems to complain :) |
ffacf08
to
04d26f9
Compare
It's now failing because of an ambiguous dependency in the examples code. quarkus-langchain4j/docs/pom.xml Line 74 in 6f40a9d
|
Yeah, we want to sample applications to build as we point users to them all the time. For the docs, you can just comment out the extension |
6a644d5
to
3221aca
Compare
It should be possible to inject the dedicated type (PineconeStore or whatever the name is) and avoid ambiguous dependency. In other parts of the doc, I mentioned that if there is only one bean of the given type in the application, you can inject it using |
I've updated the docs to add Pinecone docs and resolve the ambiguities..
|
"application.properties")); | ||
|
||
@Inject | ||
PineconeEmbeddingStore embeddingStore; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does @Inject EmbeddingStore
work too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now, @Inject EmbeddingStore
works, but if #73 is OK I will update also it here to accept @Inject EmbeddingStore<TextSegment>
, it's better than using the raw type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, let's rebase this after that one is in
No description provided.