-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to jdk17 #160
Update to jdk17 #160
Conversation
@ricardozanini could you take a look? |
@hbelmiro could you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Many thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this is needed @nmirasch? If the idea is to drop support for Java 11, we should also update other GH Actions and the pom.xml.
@hbelmiro we had a problem with Quarkus 3 integration branch. It seems fixed, but Quarkus is moving on, we should also. wdyt? |
@hbelmiro my intention was just to fix the build, but maybe we need to change <maven.compiler.target> in pom.xml too. I think the Quarkus 3 integration also needs this jdk update to 17. Wdyt? And about "we should also update other GH Actions".. which ones? (I only find the ref in this two workflows) |
That's totally fine for me to upgrade to 17. Just the intention of the PR that was not clear to me.
Yeah, you're right @nmirasch. I thought there were more GH Actions to update, but there aren't. Just pom.xml. |
@ricardozanini will we drop support for quarkus 2 here and in https://github.com/quarkiverse/quarkus-reactive-messaging-http too? |
Let's do it! |
No description provided.