Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to jdk17 #160

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Update to jdk17 #160

merged 2 commits into from
Jan 19, 2024

Conversation

nmirasch
Copy link
Contributor

No description provided.

@nmirasch
Copy link
Contributor Author

@ricardozanini could you take a look?

@nmirasch
Copy link
Contributor Author

@hbelmiro could you take a look?

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Many thanks!

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is needed @nmirasch? If the idea is to drop support for Java 11, we should also update other GH Actions and the pom.xml.

@ricardozanini
Copy link
Member

@hbelmiro we had a problem with Quarkus 3 integration branch. It seems fixed, but Quarkus is moving on, we should also. wdyt?

@nmirasch
Copy link
Contributor Author

nmirasch commented Jan 19, 2024

@hbelmiro my intention was just to fix the build, but maybe we need to change <maven.compiler.target> in pom.xml too. I think the Quarkus 3 integration also needs this jdk update to 17. Wdyt?

And about "we should also update other GH Actions".. which ones? (I only find the ref in this two workflows)

@hbelmiro
Copy link
Contributor

That's totally fine for me to upgrade to 17. Just the intention of the PR that was not clear to me.

@hbelmiro my intention was just to fix the build, but maybe we need to change <maven.compiler.target> in pom.xml too. I think the Quarkus 3 integration also needs this jdk update to 17. Wdyt?

And about "we should also update other GH Actions".. which ones? (I only find the ref in this two workflows)

Yeah, you're right @nmirasch. I thought there were more GH Actions to update, but there aren't. Just pom.xml.

@nmirasch nmirasch changed the title Update github actions to jdk17 Update to jdk17 Jan 19, 2024
@hbelmiro
Copy link
Contributor

hbelmiro commented Jan 19, 2024

@ricardozanini will we drop support for quarkus 2 here and in https://github.com/quarkiverse/quarkus-reactive-messaging-http too?

@hbelmiro hbelmiro merged commit 3cd1685 into quarkiverse:main Jan 19, 2024
1 check passed
@ricardozanini
Copy link
Member

@ricardozanini will we drop support for quarkus 2 here and in https://github.com/quarkiverse/quarkus-reactive-messaging-http too?

Let's do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants