Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#140 supress Uni and Message #141

Merged
merged 3 commits into from
Dec 12, 2023
Merged

#140 supress Uni and Message #141

merged 3 commits into from
Dec 12, 2023

Conversation

mischwarz
Copy link
Contributor

Attempt to solve generation of message type when Uni, Multi and MicroProfile Reactive Message is used in method signature

@fjtirado fjtirado requested a review from ChMThiel December 12, 2023 11:47
@fjtirado
Copy link
Contributor

@mischwarz Great job. The test is failing, please review

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any Test-Data for Uni/Multi/org.eclipse.microprofile.reactive.messaging.Message?

Copy link
Contributor

@ChMThiel ChMThiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please not change the existing use-case (GecMessage<Part>) and it's test.
Please add a new one for (Uni<Message<Part>>)...

@ChMThiel ChMThiel merged commit 2719149 into quarkiverse:main Dec 12, 2023
1 check passed
@mischwarz
Copy link
Contributor Author

Thank you for your feedback! Got it going finally :)

@ChMThiel
Copy link
Contributor

Thank you for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants