Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use and document Artemis BOM, fixes #437 #679

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Use and document Artemis BOM, fixes #437 #679

merged 1 commit into from
Dec 23, 2024

Conversation

middagj
Copy link
Contributor

@middagj middagj commented Dec 19, 2024 •
edited by turing85
Loading

Also changed the quarkus.version into quarkus-version to align with Quarkus itself. And fix the $ of quarkus-artemis-version.

Resolves #437

@middagj middagj requested a review from a team as a code owner December 19, 2024 13:54
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2024 •
edited
Loading

🚦Reports for run #1626🚦

Reports will be posted here as they get available.

🥳 JUnit JVM Test passed
Passed Failed Skipped
✅ 181 ❌ 0 ⚠️ 0

You can see the report here.

🥳 JUnit Native Test passed
Passed Failed Skipped
✅ 113 ❌ 0 ⚠️ 0

You can see the report here.

@middagj middagj merged commit 4e07036 into main Dec 23, 2024
42 checks passed
@middagj middagj deleted the use-artemis-bom branch December 23, 2024 13:34
@turing85
Copy link
Contributor

@middagj do you want to take care of downstreaming to 3.2x and 3.5.x. or should I take care of it?

@middagj
Copy link
Contributor Author

middagj commented Dec 23, 2024

How does it work, cherry pick the commit on the branches?

@turing85
Copy link
Contributor

turing85 commented Dec 23, 2024 •
edited
Loading

@middagj Yes, and then push (without a PR).
I just checked, we cannot downstream to 3.2.x since it still uses artemi 2.32.0 and the bom is only available starting with 2.33.0. So we can only to downstream to 3.5.x.

@middagj
Copy link
Contributor Author

middagj commented Dec 23, 2024

I see you were ahead of me thanks!

@turing85
Copy link
Contributor

np 😉

@turing85 turing85 mentioned this pull request Dec 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turing85 turing85 turing85 approved these changes

Assignees

@middagj middagj

Labels
backport-3.5.x enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support simple way to override/define the client version
2 participants
@middagj @turing85