Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup integration tests #322

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Conversation

turing85
Copy link
Contributor

@turing85 turing85 commented Nov 3, 2023

  • When no message can be received, return null
  • Where possible, rely on RestAssured

Copy link

github-actions bot commented Nov 3, 2023

🚦Reports for run #777🚦

Reports will be posted here as they get available.

🥳 JUnit JVM Test passed

Passed Failed Skipped
✅ 170 ❌ 0 ⚠️ 0

You can see the report here.

🥳 JUnit Native Test passed

Passed Failed Skipped
✅ 109 ❌ 0 ⚠️ 0

You can see the report here.

Copy link
Contributor

@middagj middagj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is up with the formatter?

@turing85
Copy link
Contributor Author

turing85 commented Nov 3, 2023

What is up with the formatter?

Do you mean the // @formatter:off? If you take it out, the formatter is of the oppinion that all of this should go on one line. Or on two, with random line breaks. Not really readable. I find that the test flow is much more readable with those line breaks

@turing85 turing85 merged commit 53f86d8 into main Nov 3, 2023
41 checks passed
@turing85 turing85 deleted the maintenance/cleanup-integration-tests branch November 3, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants