Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add url for search.quarkus.io to be used in the templates #159

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marko-bekhta
Copy link

required for quarkiverse/antora-ui-quarkiverse#70

The theme template uses an environment variable for the search service, which should be defined when the site is built.

Copy link
Contributor

🚀 PR Preview 7a99bfa has been successfully built and deployed to https://quarkiverse-docs-pr-159-preview.surge.sh

@gastaldi
Copy link
Member

Can we use Antora's features and make it an Asciidoc Attribute instead? https://docs.antora.org/antora/latest/playbook/asciidoc-attributes/

@marko-bekhta
Copy link
Author

Can we use Antora's features and make it an Asciidoc Attribute instead? https://docs.antora.org/antora/latest/playbook/asciidoc-attributes/

hmmm, it has been a while 🙈😃 ....

looking at where this one is used:

https://github.com/quarkiverse/antora-ui-quarkiverse/blob/d654b8f57850c6a9fa7565c57b271ada7886f822/gulp.d/tasks/download-search-app.js#L9

I'm not sure that we could leverage the asciidoc attribute from that particular JS script ...

@gastaldi
Copy link
Member

Ah I see, I thought it was being used in the generated pages

@gastaldi
Copy link
Member

That would require an Asciidoc extension or something else to read the values, but I am not sure it's worth the trouble. Do you want to make this PR ready for review so we can merge it?

Copy link
Contributor

🚀 PR Preview 8171407 has been successfully built and deployed to https://quarkiverse-docs-pr-159-preview.surge.sh

@marko-bekhta
Copy link
Author

I've updated related PRs. I think that we should start with:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants