Merge pull request #262 from quarckster/fix-sorting

Fix sorting
quarckster · Feb 16, 2023 · 988816d · 988816d
2 parents 06c46a3 + 0fe7d7a
commit 988816d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/resources/settings.xml b/src/resources/settings.xml
@@ -116,8 +116,8 @@
                     <default>desc</default>
                     <constraints>
                         <options>
-                            <option label="32067">asc</option>
-                            <option label="32068">desc</option>
+                            <option label="32067">desc</option>
+                            <option label="32068">asc</option>
                         </options>
                     </constraints>
                     <control type="list" format="string">

diff --git a/tests/test_unit.py b/tests/test_unit.py
@@ -26,3 +26,13 @@ def test_settings_locs(monkeypatch, loc, settings_mod):
     monkeypatch.setattr(settings_mod.xbmcaddon, "Addon", addon_mock_class)
     settings = settings_mod.Settings()
     assert settings.loc == loc
+
+
+@pytest.mark.parametrize("direction", ["asc", "desc"])
+def test_settings_sorting_direction_param(monkeypatch, direction, settings_mod):
+    addon_mock = MagicMock()
+    addon_mock.getSetting = MagicMock(return_value=direction)
+    addon_mock_class = MagicMock(return_value=addon_mock)
+    monkeypatch.setattr(settings_mod.xbmcaddon, "Addon", addon_mock_class)
+    settings = settings_mod.Settings()
+    assert settings.sorting_direction_param == "" if direction == "asc" else "-"