Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI actions on GitHub #672

Merged
merged 33 commits into from
Sep 14, 2024
Merged

Fix CI actions on GitHub #672

merged 33 commits into from
Sep 14, 2024

Conversation

pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented Sep 4, 2024 •
edited
Loading

  • update linux runners to ubuntu-22 or ubuntu-latest, but run test-mem
    job on ubuntu-20 for it for some reason fails on ubuntu-22
  • bump up CI actions to be compatible with node 20, namely bump up to
    actions/checkout@v4, actions/setup-python@v5, download-artifact@v4, upload-artifact@v4
  • update steps involving download-artifact and upload-artifact actions per
    https://github.com/actions/download-artifact/blob/main/docs/MIGRATION.md
  • migrate to docker compose v2
  • to build binary wheels for mac os, set MACOSX_DEPLOYMENT_TARGET according
    to the macos version
  • stop building and testing wheels for old Python versions 3.7, 3.8

pavoljuhas and others added 28 commits September 4, 2024 13:21
@pavoljuhas
No change, just trigger the CI
1eb0d6b
@pavoljuhas
CI - migrate to docker compose v2
b45a20a 
Recent GHA runner images require docker-compose v2.

Ref: actions/runner-images#9557
@pavoljuhas
Try to run ci on ubuntu-22
f5d45bd
@pavoljuhas
Stop testing wheels for Python 3.7
cbd1da0 
That version is possibly too old.  Wheels for newer Python versions
appear to build successfully.
@pavoljuhas
For some reason the test-mem CI job fails on ubuntu-22, but passes on…
d64fc2a 
… ubuntu-20
@pavoljuhas
Bump up to actions/checkout@v4 compatible with node20
b27ff9c 
Ref: https://github.com/actions/checkout/blob/main/CHANGELOG.md
@pavoljuhas
Bump up to actions/setup-python@v5 compatible with node20
506c6f1 
Ref: https://github.com/actions/setup-python/releases/tag/v5.0.0
@pavoljuhas
Bump up to actions/upload-artifact@v4 compatible with node20
ae4b888 
Ref: actions/upload-artifact#444 (comment)

Finalize #6445
@pavoljuhas
Bump up to cibuildwheel-2.20.0 since we are at it
91f0ae9
@pavoljuhas
Stop testing wheels for Python 3.8
09feb70 
It is nearing its end-of-life.
@pavoljuhas
REVERT ME - temporarily skip CI jobs that work fine
2b9f1e0
@pavoljuhas
Show environment variables
69a6c1d
@pavoljuhas
Show environment variables for real
e447d1a
@pavoljuhas
Try if macos-12 will build with the suggested MACOSX_DEPLOYMENT_TARGET
cd04853
@pavoljuhas
ugh put that MACOSX_DEPLOYMENT_TARGET in a tested workflow
1d47b34
@pavoljuhas
Downgrade to download-artifact@v3
f3251e4 
download-artifact@v4 requires some changes per
https://github.com/actions/download-artifact/blob/main/docs/MIGRATION.md
@pavoljuhas
Let us try to install libunwind on its own rather than with llvm
19b0b12
@pavoljuhas
Revert "Let us try to install libunwind on its own rather than with l…
b6f6cf1 
…lvm"

This reverts commit 19b0b12.
@pavoljuhas
Let us try if llvm@12 would do the job
4d5a47f
@pavoljuhas
And how about llvm@11?
8d61570
@pavoljuhas
Revert "And how about llvm@11?"
af8c613 
This reverts commit 8d61570.
@pavoljuhas
Try universal MACOSX_DEPLOYMENT_TARGET=13
5e17b68
@pavoljuhas
Setup MACOSX_DEPLOYMENT_TARGET per mac version of the job
2e4d98b
@pavoljuhas
Set MACOSX_DEPLOYMENT_TARGET environment variable for real
c8c0601
@pavoljuhas
Use unique names in upload-artifact@v4
e06d6da 
Ref: https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md
@pavoljuhas
Revert "REVERT ME - temporarily skip CI jobs that work fine"
693f778 
This reverts commit 2b9f1e0.
@pavoljuhas
Sync release_wheels workflow with testing_wheels
d40571a
@pavoljuhas
Bump up to actions/download-artifact@v4
2c93d85 
Handle multiple uploads per
https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md
95-martin-orion
95-martin-orion approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks passing - LGTM. Thanks for digging into this!

There are a few in-flight PRs that should be revisited now that they're unblocked by this.

@pavoljuhas
Disable CIBW_BEFORE_BUILD_MACOS
f0bddf1 
Per GHA annotations all brew libraries are already installed.
@pavoljuhas pavoljuhas marked this pull request as ready for review September 14, 2024 22:29
@pavoljuhas pavoljuhas merged commit cd646a9 into quantumlib:master Sep 14, 2024
16 checks passed
@pavoljuhas pavoljuhas deleted the fix-ci-actions branch September 14, 2024 23:05
@95-martin-orion 95-martin-orion mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@95-martin-orion 95-martin-orion 95-martin-orion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavoljuhas @95-martin-orion