Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow installing for Python 3.12 #649

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Allow installing for Python 3.12 #649

merged 3 commits into from
Jan 25, 2024

Conversation

basnijholt
Copy link
Contributor

I have tested qsim on Python 3.12 and everything works just fine.

@basnijholt
Allow installing for Python 3.12
dd26233 
I have tested qsim on Python 3.12 and everything works just fine.
@basnijholt
Build Python 3.12 wheels
8434d4f
basnijholt added a commit to basnijholt/qsimcirq-feedstock that referenced this pull request Dec 7, 2023
@basnijholt
Enable CUDA builds and apply patches from https://github.com/quantuml…
0b778d6 
…ib/qsim

- quantumlib/qsim#645
- quantumlib/qsim#646
- quantumlib/qsim#647
- quantumlib/qsim#649
@basnijholt basnijholt mentioned this pull request Dec 7, 2023
Merged
5 tasks
basnijholt added a commit to basnijholt/qsimcirq-feedstock that referenced this pull request Dec 7, 2023
@basnijholt
Enable CUDA builds and apply patches from https://github.com/quantuml…
9f8f29e 
…ib/qsim

- quantumlib/qsim#645
- quantumlib/qsim#646
- quantumlib/qsim#647
- quantumlib/qsim#649
@NoureldinYosri NoureldinYosri added the kokoro:run Trigger Kokoro builds for this PR. label Jan 24, 2024
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label Jan 24, 2024
@NoureldinYosri
Copy link
Collaborator

@basnijholt is this ready for review?

@basnijholt
Copy link
Contributor Author

basnijholt commented Jan 24, 2024 •
edited
Loading

Yes 👍

Just FYI on conda-forge we're building for Python 3.12, MacOS ARM64, and CUDA already: https://github.com/conda-forge/qsimcirq-feedstock

@NoureldinYosri NoureldinYosri merged commit a9f3968 into quantumlib:master Jan 25, 2024
17 checks passed
basnijholt added a commit to basnijholt/qsimcirq-feedstock that referenced this pull request Jan 30, 2024
@basnijholt
rm patch: quantumlib/qsim#649
79d0380
@vtomole
Copy link
Contributor

vtomole commented Jan 31, 2024

Hey @NoureldinYosri :)

When will this be deployed?

@NoureldinYosri
Copy link
Collaborator

@vtomole I will cut a new minor release after the fixes to cuda build (#645 and #652) are merged.

In the meantime you could try pip install git+https://github.com/quantumlib/qsim

@vtomole
Copy link
Contributor

vtomole commented Jan 31, 2024

Sounds good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoureldinYosri NoureldinYosri NoureldinYosri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@basnijholt @NoureldinYosri @vtomole @qsim-qsimh-bot