MPS Implementation p4: Two qubit gates. #372
Conversation
| C.noalias() = A * B.transpose(); | ||
| memcpy(raw_state + offset, raw_state + end, sizeof(fp_type) * bd * 4); | ||
| } | ||
|
|
||
| void ApplyGate2(const std::vector<unsigned>& qs, const fp_type* matrix, | ||
| State& state) const { | ||
| // TODO: micro-benchmark this function and improve performance. |
There was a problem hiding this comment.
Is this TODO resolved? If not, please open an issue for it and reference that issue here.
There was a problem hiding this comment.
It is not resolved. Opened issue here: #373
tests/mps_simulator_test.cc
Outdated
| }; | ||
| sim.ApplyGate({0, 1}, mat.data(), mps); | ||
|
|
||
| float *wf = new float[32]; |
There was a problem hiding this comment.
Same comment as the previous PR - a clarifying comment on how these wf values are generated could be helpful.
For sections with Cirq equivalents, something like this might provide the best comparison:
qsim/tests/simulator_testfixture.h
Line 471 in cae9570
(includes an equivalent Cirq code snippet)
There was a problem hiding this comment.
Added a link to Cirq code that regenerates the fuzz test as well as diagrams and explanations for the other tests. Was this what you had in mind ?
|
Looks like the Windows build encountered an error: |
Adds the two qubit gate application functionality along with tests. Other changes done in this PR:
using MPS = ....tousing State = ...in order to work withApplyGateingate_appl.h.