Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stim.FlipSimulator.broadcast_pauli_errors #678

Merged
merged 7 commits into from
Dec 11, 2023

Conversation

ghost
Copy link

@ghost ghost commented Dec 7, 2023

Addresses part of #653

Gives a general method for applying errors with 2D masks, key for speeding up interactive use of the flip simulator

@ghost ghost requested a review from Strilanc December 7, 2023 20:17
@ghost ghost self-assigned this Dec 7, 2023
Copy link
Collaborator

@Strilanc Strilanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff. A few comments.

doc/python_api_reference_vDev.md Outdated Show resolved Hide resolved
doc/python_api_reference_vDev.md Outdated Show resolved Hide resolved
doc/python_api_reference_vDev.md Outdated Show resolved Hide resolved
src/stim/simulators/frame_simulator.pybind.cc Outdated Show resolved Hide resolved
src/stim/simulators/frame_simulator.pybind.cc Outdated Show resolved Hide resolved
src/stim/simulators/frame_simulator.pybind.cc Outdated Show resolved Hide resolved
src/stim/simulators/frame_simulator.pybind.cc Outdated Show resolved Hide resolved
src/stim/simulators/frame_simulator.pybind.cc Outdated Show resolved Hide resolved
Copy link
Collaborator

@Strilanc Strilanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gettin closer

doc/python_api_reference_vDev.md Outdated Show resolved Hide resolved
doc/python_api_reference_vDev.md Outdated Show resolved Hide resolved
src/stim/simulators/frame_simulator.pybind.cc Show resolved Hide resolved
src/stim/simulators/frame_simulator_pybind_test.py Outdated Show resolved Hide resolved
src/stim/simulators/frame_simulator_pybind_test.py Outdated Show resolved Hide resolved
@ghost ghost changed the title adds apply_pauli_errors to FlipSimulator interface adds broadcast_pauli_errors to FlipSimulator interface Dec 8, 2023
Copy link
Collaborator

@Strilanc Strilanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last safety check and we're good to go.

src/stim/simulators/frame_simulator.pybind.cc Outdated Show resolved Hide resolved
@Strilanc Strilanc changed the title adds broadcast_pauli_errors to FlipSimulator interface Add broadcast_pauli_errors to FlipSimulator interface Dec 9, 2023
@Strilanc Strilanc enabled auto-merge (squash) December 10, 2023 23:47
@Strilanc Strilanc changed the title Add broadcast_pauli_errors to FlipSimulator interface Add stim.FlipSimulator.broadcast_pauli_errors Dec 10, 2023
@Strilanc Strilanc merged commit 65677df into main Dec 11, 2023
57 checks passed
@Strilanc Strilanc deleted the parallel_flip_sim_methods branch December 11, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants