Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QROAM stub #925

Closed
wants to merge 5 commits into from
Closed

QROAM stub #925

wants to merge 5 commits into from

Conversation

fdmalone
Copy link
Collaborator

@fdmalone fdmalone commented May 7, 2024

In the interim before we have a bone fide qroam bloq with decomposition (xref #368), it's important to capture the costs in a better way that what is in https://github.com/quantumlib/Qualtran/blob/main/qualtran/bloqs/chemistry/black_boxes.py#L73, i.e. the bloq has a proper signature and can be used with existing chemistry bloqs in their decompositions. This would "fix" our current costs which rely on SelectSwapQROM and results a ~ 2x discrepancy from the literature values.

TODO:

  • delete / replace the QROAM bloq in black_boxes. The downside to this is I would need to fake some input date for some bloqs which don't accept hamiltonian coefficients yet.

@fdmalone fdmalone marked this pull request as draft May 7, 2024 06:14
@fdmalone
Copy link
Collaborator Author

I'll close this in favor of @tanujkhattar suggestion which is:

  1. Add clean ancilla version of SelectSwapQROM which will fix the factor of 2 cost difference.
  2. Add a QROM adjoint bloq which uses table lookups for QROM and SelectSwapQROM^ (xref: Qrom adj #950).

SelectSwapQROM.adjoint() would then return QROM^

@fdmalone fdmalone closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant