Add a summary of QEC algorithms class #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please address comments from the previous pr and then ping me when ready for review |
mpharrigan
reviewed
Oct 10, 2023
qualtran/surface_code/quantum_error_correction_scheme_summary.py
Outdated
Show resolved
Hide resolved
qualtran/surface_code/quantum_error_correction_scheme_summary.py
Outdated
Show resolved
Hide resolved
qualtran/surface_code/quantum_error_correction_scheme_summary.py
Outdated
Show resolved
Hide resolved
|
@mpharrigan I changed the API of the class to hide the low level hardware related aspecs (e.g. |
mpharrigan
reviewed
Oct 25, 2023
| Attributes: | ||
| error_rate_scaler: Logical error rate coefficient. | ||
| error_rate_threshold: Logical error rate threshold. | ||
| reference: source of the estimates. |
There was a problem hiding this comment.
can you be more specific about what this is supposed to be. Comma separated list of urls?
There was a problem hiding this comment.
for now I see it as just a human readable string
|
|
||
| error_rate_scaler: float = field(repr=lambda x: f'{x:g}') | ||
| error_rate_threshold: float = field(repr=lambda x: f'{x:g}') | ||
| reference: str | None |
There was a problem hiding this comment.
should have default value of None
There was a problem hiding this comment.
if I do then any attribute in any class that inherets this class must have a default value
qualtran/surface_code/quantum_error_correction_scheme_summary_test.py:17: in <module>
from qualtran.surface_code import quantum_error_correction_scheme_summary as qecs
qualtran/surface_code/quantum_error_correction_scheme_summary.py:72: in <module>
class SimpliedSurfaceCode(SurfaceCode):
../../../anaconda3/envs/qualtran-env/lib/python3.10/site-packages/attr/_next_gen.py:147: in define
return wrap(maybe_cls)
../../../anaconda3/envs/qualtran-env/lib/python3.10/site-packages/attr/_next_gen.py:138: in wrap
return do_it(cls, True)
../../../anaconda3/envs/qualtran-env/lib/python3.10/site-packages/attr/_next_gen.py:83: in do_it
return attrs(
../../../anaconda3/envs/qualtran-env/lib/python3.10/site-packages/attr/_make.py:1629: in attrs
return wrap(maybe_cls)
../../../anaconda3/envs/qualtran-env/lib/python3.10/site-packages/attr/_make.py:1525: in wrap
builder = _ClassBuilder(
../../../anaconda3/envs/qualtran-env/lib/python3.10/site-packages/attr/_make.py:694: in __init__
attrs, base_attrs, base_map = _transform_attrs(
../../../anaconda3/envs/qualtran-env/lib/python3.10/site-packages/attr/_make.py:602: in _transform_attrs
raise ValueError(
E ValueError: No mandatory attributes allowed after an attribute with a default value or factory. Attribute in question: Attribute(name='error_detection_cycle_time_slope_us',
qualtran/surface_code/quantum_error_correction_scheme_summary.py
Outdated
Show resolved
Hide resolved
qualtran/surface_code/quantum_error_correction_scheme_summary.py
Outdated
Show resolved
Hide resolved
qualtran/surface_code/quantum_error_correction_scheme_summary.py
Outdated
Show resolved
Hide resolved
qualtran/surface_code/quantum_error_correction_scheme_summary.py
Outdated
Show resolved
Hide resolved
qualtran/surface_code/quantum_error_correction_scheme_summary.py
Outdated
Show resolved
Hide resolved
qualtran/surface_code/quantum_error_correction_scheme_summary.py
Outdated
Show resolved
Hide resolved
mpharrigan
reviewed
Nov 20, 2023
| error_rate_threshold: float = field(repr=lambda x: f'{x:g}') | ||
| reference: str | None | ||
|
|
||
| def logical_error_rate( |
There was a problem hiding this comment.
this is a general form of formulae.error_at. Please refactor to remove the duplicate code
There was a problem hiding this comment.
I removed the formulae.py file. the two methods there correspond to calling the appropiate methods of a SimpeSurfaceCode with the correct parameters
|
@NoureldinYosri what's the status of this? |
mpharrigan
approved these changes
Dec 1, 2023
qualtran/surface_code/quantum_error_correction_scheme_summary.py
Outdated
Show resolved
Hide resolved
qualtran/surface_code/quantum_error_correction_scheme_summary.py
Outdated
Show resolved
Hide resolved
qualtran/surface_code/quantum_error_correction_scheme_summary.py
Outdated
Show resolved
Hide resolved
qualtran/surface_code/quantum_error_correction_scheme_summary.py
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
child of #356
fixes #535