Add more arithmetic bloqs. #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Square real * Scale int by real * Multiply two reals Fix bug with bitsize for sum of squares.
|
Pulled out from #359 |
|
Oh and an out of place adder which raised #375 |
qualtran/bloqs/arithmetic.py
Outdated
| return "c = a + b" | ||
|
|
||
| def t_complexity(self): | ||
| # TODO: This is just copied from adder above, not sure if correct. |
There was a problem hiding this comment.
T count is correct. Clifford count should be inceased by bitsize.
the decomposition would be
yield CNOT.on_each(zip(b, c))
yield Add(a, c)
There was a problem hiding this comment.
can we capture this somehow? i.e. by using bloq_counts of n cnots and an Add
mpharrigan
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug with bitsize for sum of squares.