Fix QPE cirq simulation tests #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fdmalone ptal |
|
is there a more fundamental issue at play here? this seems like a hacky fix on top of the existing tests |
mpharrigan
reviewed
Nov 12, 2024
| qpe_reg, selection, target = (gh.quregs['qpe_reg'], gh.quregs['selection'], gh.quregs['target']) | ||
| qpe_bloq = QubitizationQPE(walk, state_prep) | ||
|
|
||
| def should_decompose(binst): |
There was a problem hiding this comment.
can you open an issue and link it here. I assume this isn't ideally how things would work?
There was a problem hiding this comment.
yeah, I spent some time but couldn't figure out the root cause. Opened #1495 and linked here.
mpharrigan
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cirq simulator was unable to simulate
Controlled(QubitizationWalkOperator), so decompose one level further to get simulable gates.Also made a subset fast tests to catch issues early on. Fixes the current Nightly test failure.