Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix QPE test failure, add non-slow bloq example autotest #1487

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

anurudhp
Copy link
Contributor

@anurudhp anurudhp commented Nov 6, 2024

One set of tests failed due to a signature mismatch: now added a fast bloq example test for QubitizationQPE

Another was simulation: fixed by defaulting to tensor if cirq unitary fails for controlled bloqs.

@anurudhp anurudhp force-pushed the 2024/11/06-fix-qpe-tests branch from 62ea110 to 9cb2e5e Compare November 6, 2024 22:37
@anurudhp
Copy link
Contributor Author

anurudhp commented Nov 7, 2024

@mpharrigan @fdmalone ptal!

Copy link
Collaborator

@fdmalone fdmalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nit about this silent exception

@anurudhp anurudhp requested a review from fdmalone November 7, 2024 20:10
@fdmalone
Copy link
Collaborator

fdmalone commented Nov 7, 2024

LGTM

@anurudhp
Copy link
Contributor Author

anurudhp commented Nov 7, 2024

could you merge it? (I don't have the permissions)
thanks!

@fdmalone fdmalone merged commit 188b663 into quantumlib:main Nov 7, 2024
8 checks passed
@anurudhp anurudhp deleted the 2024/11/06-fix-qpe-tests branch November 7, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants