-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup redundant code for computing t complexity #1317
Merged
anurudhp
merged 13 commits into
quantumlib:main
from
anurudhp:2024/08/20-refactor-rot-eps
Aug 23, 2024
Merged
Cleanup redundant code for computing t complexity #1317
anurudhp
merged 13 commits into
quantumlib:main
from
anurudhp:2024/08/20-refactor-rot-eps
Aug 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anurudhp
force-pushed
the
2024/08/20-refactor-rot-eps
branch
from
August 20, 2024 21:33
40a04d6
to
576560d
Compare
anurudhp
changed the title
Cleanup rotation
Cleanup redundant code for computing t complexity
Aug 20, 2024
eps
attribute
anurudhp
force-pushed
the
2024/08/20-refactor-rot-eps
branch
from
August 21, 2024 00:04
8efdb70
to
623413d
Compare
anurudhp
force-pushed
the
2024/08/20-refactor-rot-eps
branch
from
August 21, 2024 06:32
73cc574
to
a7d7681
Compare
mpharrigan
reviewed
Aug 22, 2024
mpharrigan
reviewed
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally very reasonable changes; unsure about that one test deletion
mpharrigan
reviewed
Aug 23, 2024
mpharrigan
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up some redundant code to compute t-complexity.
_get_all_rotation_types
(in favor ofbloq_is_rotation
).t_counts_from_sigma
(in favor ofQECGatesCost
).TODOs in follow up:
t_counts_from_sigma
uses eps correctly, but it's only used in a handful of places. This should be replaced withQECGatesCost
after adding support for eps (Propagate rotation epsilon in gate cost #1250).GateCounts.total_t_and_rotation_count
helper to support existing use cases which only take number of rotations (e.g. Beverland-et-al model).Relevant discussions: