Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement classical action of Cast bloq #1093

Merged
merged 4 commits into from
Jun 27, 2024
Merged

Implement classical action of Cast bloq #1093

merged 4 commits into from
Jun 27, 2024

Conversation

NoureldinYosri
Copy link
Contributor

@NoureldinYosri NoureldinYosri commented Jun 26, 2024 •
edited
Loading

fixes #734

blocking #1057

fdmalone
fdmalone approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@fdmalone fdmalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test?

@fdmalone
Copy link
Collaborator

Oh, unhashable Fxp issues

@mpharrigan
Copy link
Collaborator

why is it trying to cache a fxp?

@NoureldinYosri
Copy link
Contributor Author

I created #1095 to track support for QFxp

@NoureldinYosri NoureldinYosri merged commit 79a880b into quantumlib:main Jun 27, 2024
7 checks passed
@NoureldinYosri NoureldinYosri deleted the cast branch June 27, 2024 20:52
@NoureldinYosri NoureldinYosri mentioned this pull request Aug 23, 2024
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdmalone fdmalone fdmalone approved these changes

Assignees
No one assigned
Labels
sim/classical
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data types] Cast bloq classical simulation should cast the values.
3 participants
@NoureldinYosri @fdmalone @mpharrigan