-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow passing a callable to de/serialization funcs #6855
Merged
senecameeks
merged 11 commits into
quantumlib:main
from
senecameeks:u/smeeks/const_unit
Dec 19, 2024
+128
−18
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7f14e95
allow passing func to de/serialization funcs
senecameeks a698811
coverage
senecameeks a5f3c0c
simplify
senecameeks 796cec2
Merge branch 'main' into u/smeeks/const_unit
senecameeks d41d3da
typecheck
senecameeks 45c478d
nit
senecameeks 34b023c
mypy
senecameeks 00e3c4c
comments
senecameeks ded46f6
Merge branch 'main' into u/smeeks/const_unit
senecameeks 9158451
comments
senecameeks 8cb0db8
Merge branch 'u/smeeks/const_unit' of github.com:senecameeks/Cirq int…
senecameeks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add another test that
add tunit
insweep_to_proto
whileremove tunit
insweep_from_proto
, this is a more practical usage in the pyle.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done