-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create workflow for Z-phase calibration #6728
Changes from 20 commits
ade51ee
145880e
9a9d06f
d37ea60
717155c
b053a93
eadda56
07ba30a
8c244e7
552b7df
6f71abf
39b1537
e2cac7d
9f42000
26593a1
39e0a6d
d0a9583
530dc2d
55c47a5
0cb890d
5d668e2
a372c8e
fcb2d2a
d9a8282
b19cee9
360aee1
296922d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,271 @@ | ||
# Copyright 2024 The Cirq Developers | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# https://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
"""Provides a method to do z-phase calibration for excitation-preserving gates.""" | ||
from typing import Union, Optional, Sequence, Tuple, Dict, TYPE_CHECKING | ||
|
||
import multiprocessing | ||
import multiprocessing.pool | ||
NoureldinYosri marked this conversation as resolved.
Show resolved
Hide resolved
|
||
import matplotlib.pyplot as plt | ||
import numpy as np | ||
|
||
from cirq.experiments import xeb_fitting | ||
from cirq.experiments.two_qubit_xeb import parallel_xeb_workflow | ||
from cirq import ops | ||
|
||
if TYPE_CHECKING: | ||
import cirq | ||
import pandas as pd | ||
|
||
|
||
def z_phase_calibration_workflow( | ||
sampler: 'cirq.Sampler', | ||
qubits: Optional[Sequence['cirq.GridQubit']] = None, | ||
two_qubit_gate: 'cirq.Gate' = ops.CZ, | ||
options: Optional[xeb_fitting.XEBPhasedFSimCharacterizationOptions] = None, | ||
n_repetitions: int = 10**4, | ||
n_combinations: int = 10, | ||
n_circuits: int = 20, | ||
cycle_depths: Sequence[int] = tuple(np.arange(3, 100, 20)), | ||
random_state: 'cirq.RANDOM_STATE_OR_SEED_LIKE' = None, | ||
atol: float = 1e-3, | ||
pool_or_num_workers: Optional[Union[int, 'multiprocessing.pool.Pool']] = None, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please make a single-process execution the default behavior of the pool argument. I would also recommend to split the
which would be more robust for closing the pool in case of exception, you'd also won't need to track a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
this was the initial behaviour but @eliottrosenberg requested the default be multiprocessing
I condidered this but I thought the api would be a bit convoluted There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @pavoljuhas I think that most users would use it with the default values without passing a parallel pool, and it is very slow that way. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My concern is all other functions with Can we instead use some reasonable default, say 4, and not accept Also renaming to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
) -> Tuple[xeb_fitting.XEBCharacterizationResult, 'pd.DataFrame']: | ||
"""Perform z-phase calibration for excitation-preserving gates. | ||
|
||
For a given excitation-preserving two-qubit gate we assume an error model that can be described | ||
using Z-rotations: | ||
0: ───Rz(a)───two_qubit_gate───Rz(c)─── | ||
│ | ||
1: ───Rz(b)───two_qubit_gate───Rz(d)─── | ||
for some angles a, b, c, and d. | ||
|
||
Since the two-qubit gate is a excitation-preserving-gate, it can be represented by an FSimGate | ||
and the effect of rotations turns it into a PhasedFSimGate. Using XEB-data we find the | ||
PhasedFSimGate parameters that minimize the infidelity of the gate. | ||
|
||
References: | ||
- https://arxiv.org/abs/2001.08343 | ||
- https://arxiv.org/abs/2010.07965 | ||
- https://arxiv.org/abs/1910.11333 | ||
|
||
Args: | ||
sampler: The quantum engine or simulator to run the circuits. | ||
qubits: Qubits to use. If none, use all qubits on the sampler's device. | ||
two_qubit_gate: The entangling gate to use. | ||
options: The XEB-fitting options. If None, calibrate all 5 PhasedFSimGate parameters, | ||
using the representation of a two-qubit gate as an FSimGate for the initial guess. | ||
n_repetitions: The number of repetitions to use. | ||
n_combinations: The number of combinations to generate. | ||
n_circuits: The number of circuits to generate. | ||
cycle_depths: The cycle depths to use. | ||
random_state: The random state to use. | ||
atol: Absolute tolerance to be used by the minimizer. | ||
pool_or_num_workers: An optional multi-processing pool or number of workers. | ||
A zero value means no multiprocessing. | ||
A positivie integer value will create a pool with the given number of workers. | ||
NoureldinYosri marked this conversation as resolved.
Show resolved
Hide resolved
|
||
A None value will create pool with maximum number of workers. | ||
Returns: | ||
- An `XEBCharacterizationResult` object that contains the calibration result. | ||
- A `pd.DataFrame` comparing the before and after fidelities. | ||
""" | ||
|
||
pool: Optional['multiprocessing.pool.Pool'] = None | ||
local_pool = False | ||
if isinstance(pool_or_num_workers, multiprocessing.pool.Pool): | ||
pool = pool_or_num_workers # pragma: no cover | ||
elif pool_or_num_workers != 0: | ||
pool = multiprocessing.Pool(pool_or_num_workers) | ||
local_pool = True | ||
|
||
fids_df_0, circuits, sampled_df = parallel_xeb_workflow( | ||
sampler=sampler, | ||
qubits=qubits, | ||
entangling_gate=two_qubit_gate, | ||
n_repetitions=n_repetitions, | ||
cycle_depths=cycle_depths, | ||
n_circuits=n_circuits, | ||
n_combinations=n_combinations, | ||
random_state=random_state, | ||
pool=pool, | ||
) | ||
|
||
if options is None: | ||
options = xeb_fitting.XEBPhasedFSimCharacterizationOptions( | ||
characterize_chi=True, | ||
characterize_gamma=True, | ||
characterize_zeta=True, | ||
characterize_theta=False, | ||
characterize_phi=False, | ||
NoureldinYosri marked this conversation as resolved.
Show resolved
Hide resolved
|
||
).with_defaults_from_gate(two_qubit_gate) | ||
|
||
p_circuits = [ | ||
xeb_fitting.parameterize_circuit(circuit, options, ops.GateFamily(two_qubit_gate)) | ||
for circuit in circuits | ||
] | ||
|
||
result = xeb_fitting.characterize_phased_fsim_parameters_with_xeb_by_pair( | ||
sampled_df=sampled_df, | ||
parameterized_circuits=p_circuits, | ||
cycle_depths=cycle_depths, | ||
options=options, | ||
fatol=atol, | ||
xatol=atol, | ||
pool=pool, | ||
) | ||
|
||
before_after = xeb_fitting.before_and_after_characterization( | ||
fids_df_0, characterization_result=result | ||
) | ||
|
||
if local_pool: | ||
assert isinstance(pool, multiprocessing.pool.Pool) | ||
pool.close() | ||
return result, before_after | ||
|
||
|
||
def calibrate_z_phases( | ||
sampler: 'cirq.Sampler', | ||
qubits: Optional[Sequence['cirq.GridQubit']] = None, | ||
two_qubit_gate: 'cirq.Gate' = ops.CZ, | ||
options: Optional[xeb_fitting.XEBPhasedFSimCharacterizationOptions] = None, | ||
n_repetitions: int = 10**4, | ||
n_combinations: int = 10, | ||
n_circuits: int = 20, | ||
cycle_depths: Sequence[int] = tuple(np.arange(3, 100, 20)), | ||
random_state: 'cirq.RANDOM_STATE_OR_SEED_LIKE' = None, | ||
atol: float = 1e-3, | ||
pool_or_num_workers: Optional[Union[int, 'multiprocessing.pool.Pool']] = None, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please make single process the default and split to 2 arguments as suggested above for z_phase_calibration_workflow. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
) -> Dict[Tuple['cirq.Qid', 'cirq.Qid'], 'cirq.PhasedFSimGate']: | ||
"""Perform z-phase calibration for excitation-preserving gates. | ||
|
||
For a given excitation-preserving two-qubit gate we assume an error model that can be described | ||
using Z-rotations: | ||
0: ───Rz(a)───two_qubit_gate───Rz(c)─── | ||
│ | ||
1: ───Rz(b)───two_qubit_gate───Rz(d)─── | ||
for some angles a, b, c, and d. | ||
|
||
Since the two-qubit gate is a excitation-preserving gate, it can be represented by an FSimGate | ||
and the effect of rotations turns it into a PhasedFSimGate. Using XEB-data we find the | ||
PhasedFSimGate parameters that minimize the infidelity of the gate. | ||
|
||
References: | ||
- https://arxiv.org/abs/2001.08343 | ||
- https://arxiv.org/abs/2010.07965 | ||
- https://arxiv.org/abs/1910.11333 | ||
|
||
Args: | ||
sampler: The quantum engine or simulator to run the circuits. | ||
qubits: Qubits to use. If none, use all qubits on the sampler's device. | ||
two_qubit_gate: The entangling gate to use. | ||
options: The XEB-fitting options. If None, calibrate all 5 PhasedFSimGate parameters, | ||
using the representation of a two-qubit gate as an FSimGate for the initial guess. | ||
n_repetitions: The number of repetitions to use. | ||
n_combinations: The number of combinations to generate. | ||
n_circuits: The number of circuits to generate. | ||
cycle_depths: The cycle depths to use. | ||
random_state: The random state to use. | ||
atol: Absolute tolerance to be used by the minimizer. | ||
pool_or_num_workers: An optional multi-processing pool or number of workers. | ||
A zero value means no multiprocessing. | ||
A positivie integer value will create a pool with the given number of workers. | ||
NoureldinYosri marked this conversation as resolved.
Show resolved
Hide resolved
|
||
A None value will create pool with maximum number of workers. | ||
|
||
Returns: | ||
- A dictionary mapping qubit pairs to the calibrated PhasedFSimGates. | ||
""" | ||
|
||
if options is None: | ||
options = xeb_fitting.XEBPhasedFSimCharacterizationOptions( | ||
characterize_chi=True, | ||
characterize_gamma=True, | ||
characterize_zeta=True, | ||
characterize_theta=False, | ||
characterize_phi=False, | ||
NoureldinYosri marked this conversation as resolved.
Show resolved
Hide resolved
|
||
).with_defaults_from_gate(two_qubit_gate) | ||
|
||
result, _ = z_phase_calibration_workflow( | ||
sampler=sampler, | ||
qubits=qubits, | ||
two_qubit_gate=two_qubit_gate, | ||
options=options, | ||
n_repetitions=n_repetitions, | ||
n_combinations=n_combinations, | ||
n_circuits=n_circuits, | ||
cycle_depths=cycle_depths, | ||
random_state=random_state, | ||
atol=atol, | ||
pool_or_num_workers=pool_or_num_workers, | ||
) | ||
|
||
gates = {} | ||
for pair, params in result.final_params.items(): | ||
params['theta'] = params.get('theta', options.theta_default or 0) | ||
params['phi'] = params.get('phi', options.phi_default or 0) | ||
params['zeta'] = params.get('zeta', options.zeta_default or 0) | ||
params['chi'] = params.get('chi', options.chi_default or 0) | ||
params['gamma'] = params.get('gamma', options.gamma_default or 0) | ||
gates[pair] = ops.PhasedFSimGate(**params) | ||
return gates | ||
|
||
|
||
def plot_z_phase_calibration_result( | ||
before_after_df: 'pd.DataFrame', | ||
axes: Optional[np.ndarray[Sequence[Sequence['plt.Axes']], np.dtype[np.object_]]] = None, | ||
pairs: Optional[Sequence[Tuple['cirq.Qid', 'cirq.Qid']]] = None, | ||
*, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @eliottrosenberg - Would it be useful to provide an optional There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added that option |
||
with_error_bars: bool = False, | ||
) -> np.ndarray[Sequence[Sequence['plt.Axes']], np.dtype[np.object_]]: | ||
"""A helper method to plot the result of running z-phase calibration. | ||
|
||
Note that the plotted fidelity is a statistical estimate of the true fidelity and as a result | ||
may be outside the [0, 1] range. | ||
|
||
Args: | ||
before_after_df: The second return object of running `z_phase_calibration_workflow`. | ||
axes: And ndarray of the axes to plot on. | ||
The number of axes is expected to be >= number of qubit pairs. | ||
pairs: If provided, only the given pairs are plotted. | ||
with_error_bars: Whether to add error bars or not. | ||
The width of the bar is an upper bound on standard variation of the estimated fidelity. | ||
""" | ||
if pairs is None: | ||
pairs = before_after_df.index | ||
if axes is None: | ||
# Create a 16x9 rectangle. | ||
ncols = int(np.ceil(np.sqrt(9 / 16 * len(pairs)))) | ||
nrows = (len(pairs) + ncols - 1) // ncols | ||
_, axes = plt.subplots(nrows=nrows, ncols=ncols) | ||
axes = axes if isinstance(axes, np.ndarray) else np.array(axes) | ||
for pair, ax in zip(pairs, axes.flatten()): | ||
row = before_after_df.loc[[pair]].iloc[0] | ||
ax.errorbar( | ||
row.cycle_depths_0, | ||
row.fidelities_0, | ||
yerr=row.layer_fid_std_0 * with_error_bars, | ||
label='original', | ||
) | ||
ax.errorbar( | ||
row.cycle_depths_0, | ||
row.fidelities_c, | ||
yerr=row.layer_fid_std_c * with_error_bars, | ||
label='calibrated', | ||
) | ||
ax.axhline(1, linestyle='--') | ||
ax.set_xlabel('cycle depth') | ||
ax.set_ylabel('fidelity estimate') | ||
ax.set_title('-'.join(str(q) for q in pair)) | ||
ax.legend() | ||
return axes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a little redundant to have both
calibrate_z_phases
andz_phase_calibration_workflow
. Can we just have one thing with the functionality ofz_phase_calibration_workflow
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On an unrelated note, please use the
from somewhere import foo as foo
so that the new names can be imported from cirq.experiments without raising mypy error. (Ref: #6717)