Ignore spurious PollerCompletionQueue errors in AsyncioExecutor #6492
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maffoo
requested review from
wcourtney,
vtomole,
cduck,
verult and
a team
as code owners
verult
reviewed
Mar 12, 2024
| @@ -40,6 +41,13 @@ def __init__(self) -> None: | |||
|
|
|||
| @staticmethod | |||
| async def _main(loop_future: duet.AwaitableFuture) -> None: | |||
| def handle_exception(loop, context) -> None: | |||
There was a problem hiding this comment.
Is this function called somewhere?
There was a problem hiding this comment.
Oops, forgot to actually set this as the exception handler. Fixed.
|
Note: I filed grpc/grpc#36096 to fix these errors upstream. We'll see what comes of that, but in any case it will be a while before we can rely on that and so I think silencing these errors in our own event loops makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using grpc with asyncio from multiple threads, spurious
PollerCompletionQueueerrors are printed due to multiple event loops listening a socket to be notified of grpc events. More than one event loop may be woken when the completion queue writes a byte to the notification socket, but only one of the loops receives the data and the others raise aBlockingIOError. This doesn't actually cause a problem in the grpc still works with asyncio in multiple threads, but lots of spurious error messages are printed by the default exception handler. (See grpc/grpc#25364 for discussion of the issue.)This configures the asyncio event loop used for grpc with an exception handler that ignores these
BlockingIOErrors from thePollerCompletionQueueso that we don't spam the logs with scary-looking messages when using grpc with asyncio from multiple threads.