Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial on symmetric tensors #27

Merged
merged 5 commits into from
Feb 24, 2024
Merged

Add tutorial on symmetric tensors #27

merged 5 commits into from
Feb 24, 2024

Conversation

leburgel
Copy link
Collaborator

A first attempt at an in-depth but (hopefully) intuitive tutorial on constructing symmetric tensors representing Hamintonians in concrete physical systems using TensorKit.jl.

Copy link

github-actions bot commented Feb 22, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-02-24 18:48 UTC

@Jutho
Copy link
Contributor

Jutho commented Feb 22, 2024

This looks amazing. I will try to read it in detail soon.

Copy link
Contributor

@Jutho Jutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look's great!

lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
Copy link
Contributor

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing.
I would advice using something either like the VScode extension Reflow Markdown to limit the line length, or just cut lines at the end of a sentence. This also makes git behave better.
The only remark I would have is distinguishing between what we commonly call big blocks and small blocks a bit more clearly, as this is quite important to work with TensorMaps.
I think tensor map does not look as nice as just TensorMap, so mayb a ctrl+f on this would be good as well, as I might have missed a couple

lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
@leburgel
Copy link
Collaborator Author

I think I addressed all of the comments. I added a little discussion about the 'big' matrix blocks in the actual block-diagonal decomposition in terms of coupled charges, and the 'small' array blocks associated to each fusion tree. It's at the end of section 18.2.1. I hope this clarifies things instead of just making it more confusion. If it's still not clear I can have another go.

Copy link
Contributor

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor typos left, otherwise looks ready to go

lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
lectures/5-Tutorials/SymmetricTensors.md Outdated Show resolved Hide resolved
@leburgel leburgel merged commit dca980e into main Feb 24, 2024
1 check passed
@leburgel leburgel deleted the lb/sometutorials branch February 24, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants