Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
leburgel committed Feb 8, 2024
1 parent c78ed21 commit 662fc34
Show file tree
Hide file tree
Showing 8 changed files with 23 additions and 51 deletions.
2 changes: 1 addition & 1 deletion src/algorithms/IDmrg.m
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
%
% dynamical_tols : :class:`logical`
% indicate whether or not to use a dynamical tolerance scaling for the algorithm's
% subroutines based on the current error measure, defaults to :code:`false`
% subroutines based on the current error measure, defaults to :code:`false`.
%
% tol_min : :class:`double`
% smallest allowed convergence tolerance for soubroutines, defaults to :code:`1e-12`.
Expand Down
2 changes: 1 addition & 1 deletion src/algorithms/IDmrg2.m
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
%
% dynamical_tols : :class:`logical`
% indicate whether or not to use a dynamical tolerance scaling for the algorithm's
% subroutines based on the current error measure, defaults to :code:`false`
% subroutines based on the current error measure, defaults to :code:`false`.
%
% tol_min : :class:`double`
% smallest allowed convergence tolerance for soubroutines, defaults to :code:`1e-12`.
Expand Down
2 changes: 1 addition & 1 deletion src/algorithms/Vomps.m
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
%
% dynamical_tols : :class:`logical`
% indicate whether or not to use a dynamical tolerance scaling for the algorithm's
% subroutines based on the current error measure, defaults to :code:`true`
% subroutines based on the current error measure, defaults to :code:`true`.
%
% tol_min : :class:`double`
% smallest allowed convergence tolerance for soubroutines, defaults to :code:`1e-12`.
Expand Down
2 changes: 1 addition & 1 deletion src/algorithms/Vumps.m
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
%
% dynamical_tols : :class:`logical`
% indicate whether or not to use a dynamical tolerance scaling for the algorithm's
% subroutines based on the current error measure, defaults to :code:`true`
% subroutines based on the current error measure, defaults to :code:`true`.
%
% tol_min : :class:`double`
% smallest allowed convergence tolerance for soubroutines, defaults to :code:`1e-12`.
Expand Down
28 changes: 0 additions & 28 deletions src/mps/UniformMps.m
Original file line number Diff line number Diff line change
Expand Up @@ -940,34 +940,6 @@ function plot_entanglementspectrum(mps, d, w, ax, kwargs)
end
end

% S = EntanglementEntropy(mps, loc);
% S = RenyiEntropy(mps,n, loc);
% E = ExpectationValue(mps, W, GL, GR)
% rho = LeftFixedPoint(mps1, mps2, w, choice)
% rho = RightFixedPoint(mps1, mps2, w, choice)
% sf=StaticStructureFactor(mps,S,k)
%
% out = Block(mps, opts)
% out = Split(mps, varargin)
% %[out, lambda] = Truncate(mps, control, opts)
%
% [f, rho] = Fidelity(mps1, mps2, tol)
%
% mps = Conj(mps)
%
% mps = mtimes(mps, lambda)
%
% mps = ShiftUnitCell(mps,dd,dw)
% out = Rotate180(mps)
% out = Transpose(mps)
%
% mps = SendToGpu(mps)
% mps = GetFromGpu(mps)
%
% [mps, xi] = Retract(mps, eta, alpha)
% n = Inner(x, eta, xi)


end

%% Subroutines
Expand Down
34 changes: 17 additions & 17 deletions src/tensors/Tensor.m
Original file line number Diff line number Diff line change
Expand Up @@ -1566,12 +1566,12 @@
% alg : :class:`char` or :class:`string`
% selection of algorithms for the decomposition:
%
% - 'qr' produces an upper triangular remainder R
% - 'qrpos' corrects the diagonal elements of R to be positive.
% - 'ql' produces a lower triangular remainder R
% - 'qlpos' corrects the diagonal elements of R to be positive.
% - 'polar' produces a Hermitian and positive semidefinite R.
% - 'svd' uses a singular value decomposition.
% - :code:`'qr'` produces an upper triangular remainder R
% - :code:`'qrpos'` corrects the diagonal elements of R to be positive.
% - :code:`'ql'` produces a lower triangular remainder R
% - :code:`'qlpos'` corrects the diagonal elements of R to be positive.
% - :code:`'polar'` produces a Hermitian and positive semidefinite R.
% - :code:`'svd'` uses a singular value decomposition.
%
% Returns
% -------
Expand Down Expand Up @@ -1647,12 +1647,12 @@
% alg : :class:`char` or :class:`string`
% selection of algorithms for the decomposition:
%
% - 'rq' produces an upper triangular remainder R
% - 'rqpos' corrects the diagonal elements of R to be positive.
% - 'lq' produces a lower triangular remainder R
% - 'lqpos' corrects the diagonal elements of R to be positive.
% - 'polar' produces a Hermitian and positive semidefinite R.
% - 'svd' uses a singular value decomposition.
% - :code:`'rq'` produces an upper triangular remainder R
% - :code:`'rqpos'` corrects the diagonal elements of R to be positive.
% - :code:`'lq'` produces a lower triangular remainder R
% - :code:`'lqpos'` corrects the diagonal elements of R to be positive.
% - :code:`'polar'` produces a Hermitian and positive semidefinite R.
% - :code:`'svd'` uses a singular value decomposition.
%
% Returns
% -------
Expand Down Expand Up @@ -1723,8 +1723,8 @@
% alg : :class:`char` or :class:`string`
% selection of algorithms for the nullspace:
%
% - 'svd'
% - 'qr'
% - :code:`'svd'`
% - :code:`'qr'`
%
% Returns
% -------
Expand Down Expand Up @@ -1793,8 +1793,8 @@
% alg : :class:`char` or :class:`string`
% selection of algorithms for the nullspace:
%
% - 'svd'
% - 'lq'
% - :code:`'svd'`
% - :code:`'lq'`
%
% Returns
% -------
Expand Down Expand Up @@ -2224,7 +2224,7 @@
% Returns
% -------
% bool : :class:`logical`
% true if t is isometric.
% true if :code:`t` is isometric.

arguments
t
Expand Down
2 changes: 1 addition & 1 deletion src/tensors/charges/AbstractCharge.m
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
% Returns
% -------
% abar : :class:`.AbstractCharge`
% conjugate charge suche that :code:`one(a)` is an element of :code:`a * abar`
% conjugate charge such that :code:`one(a)` is an element of :code:`a * abar`
error('AbstractCharge:requiredMethod', ...
'Error. \nMethod must be overloaded.')
end
Expand Down
2 changes: 1 addition & 1 deletion src/utility/swapvars.m
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
% Usage
% -----
% :code:`[a, b] = swapvars(a, b)`
% stores the value of :code:`a` in :code:`b`, and the value of :code:`b in :code:`a`.
% stores the value of :code:`a` in :code:`b`, and the value of :code:`b` in :code:`a`.

end

0 comments on commit 662fc34

Please sign in to comment.