Fix button toggle and support lightbox #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- not needed if using the example as provided
- detects manual change via dark/light input as well as browser preference changes. - extends support to the glightbox plugin - uses transparent plantuml drawings
- update mkdocs example to include lightbox - produce a new gif demo - update readme
- cleanup header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue wherein the light/dark switch was not being detected when using the mkdocs-material built-in toggle.
I resolved it by updating the switch_dark.js to account for it. Once that was fixed I found another issue with lightbox functionality when using this plugin, the lightbox image reference gets updated but we need to restart lightbox in order for it to access the new one.
Demo:
