Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds masking functionality #186

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

adds masking functionality #186

wants to merge 2 commits into from

Conversation

derNarr
Copy link
Member

@derNarr derNarr commented Aug 10, 2020

Changes proposed in this pull request:

  • adds new keyword argument to ndl learners cues_to_mask which allows to specify a set of cues that will not learn to predict themselves if they appear as cues and as outcomes.

Todos:

  • At the moment the low level Cython code is duplicated and slightly changed. This should yield the smallest speed penalty as otherwise an extra condition has to be checked in the most inner loop. But if the compiler is smart enough to implement it branchless, the code should be rewritten to have no code duplication. Timings are needed here.
  • Should masked be renamed to masking in the low level functions?
  • split tests into tests that run on MacOS and Windows and those which run on Linux only

@derNarr derNarr self-assigned this Aug 10, 2020
@coveralls
Copy link

coveralls commented Aug 10, 2020

Coverage Status

Coverage increased (+0.6%) to 83.704% when pulling cd36607 on masking2 into a32093c on master.

@lgtm-com
Copy link

lgtm-com bot commented Aug 10, 2020

This pull request introduces 3 alerts when merging 64ac6ad into 7a488dd - view on LGTM.com

new alerts:

  • 3 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Nov 5, 2020

This pull request introduces 3 alerts when merging cd36607 into a32093c - view on LGTM.com

new alerts:

  • 3 for Unused local variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants