Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow improvements #3465

Merged
merged 10 commits into from
Dec 26, 2024
Merged

Workflow improvements #3465

merged 10 commits into from
Dec 26, 2024

Conversation

berekuk
Copy link
Collaborator

@berekuk berekuk commented Dec 24, 2024

Various quality-of-life improvements.

Show workflow date and step duration:
Screenshot 2024-12-24 at 16 20 16
Screenshot 2024-12-24 at 16 20 34

Use Squiggle v0.10 instead of Next in AI playgrounds.

Admin mode:
Screenshot 2024-12-24 at 16 21 33

On click, it will reveal admin-only controls (in the future, useful not only in Squiggle AI, but everywhere, globally available through context):
Screenshot 2024-12-24 at 16 21 54

"Show all" will show all existing workflows in the database, useful for debugging:
Screenshot 2024-12-24 at 16 22 15

Workflows created more than 5 minutes ago will show as Failed and "Timed Out", instead of infinite spinner:
Screenshot 2024-12-24 at 16 23 26

@berekuk berekuk requested a review from OAGr as a code owner December 24, 2024 19:24
Copy link

changeset-bot bot commented Dec 24, 2024

⚠️ No Changeset found

Latest commit: d9393c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Dec 24, 2024 7:25pm
quri-ui ✅ Ready (Inspect) Visit Preview Dec 24, 2024 7:25pm
squiggle-components ✅ Ready (Inspect) Visit Preview Dec 24, 2024 7:25pm
squiggle-website ✅ Ready (Inspect) Visit Preview Dec 24, 2024 7:25pm

@OAGr
Copy link
Contributor

OAGr commented Dec 24, 2024

Seems like an improvement!

image

For these that time out, one future task is to try to fix these. As in, at least, figure out why it's crashing on the backend, and/or when it does, then have it fail gracefully. Make an official Markdown log and the like.

@OAGr
Copy link
Contributor

OAGr commented Dec 24, 2024

Very minor, but maybe at some point we could change the Fire icon to a "key", "ID" or maybe "shield", to better represent admins?

image image

@berekuk
Copy link
Collaborator Author

berekuk commented Dec 26, 2024

Very minor, but maybe at some point we could change the Fire icon to a "key"

Yeah, I considered this but didn't want to spend extra 10 min on an extra icon in admin-only UI; I'll do this some time later.

@berekuk berekuk merged commit 522aa06 into main Dec 26, 2024
6 checks passed
@berekuk berekuk deleted the workflow-improvements branch December 26, 2024 16:40
@OAGr
Copy link
Contributor

OAGr commented Dec 26, 2024

Yeah, I considered this but didn't want to spend extra 10 min on an extra icon in admin-only UI; I'll do this some time later.

Makes sense, I agree with that prioritization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants