Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Publish" in Squiggle AI #3464

Merged
merged 7 commits into from
Dec 23, 2024
Merged

"Publish" in Squiggle AI #3464

merged 7 commits into from
Dec 23, 2024

Conversation

berekuk
Copy link
Collaborator

@berekuk berekuk commented Dec 21, 2024

(done on top of still unmerged #3463)

@berekuk berekuk requested a review from OAGr as a code owner December 21, 2024 17:52
Copy link

changeset-bot bot commented Dec 21, 2024

⚠️ No Changeset found

Latest commit: bb91ab6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Dec 23, 2024 8:39pm
3 Skipped Deployments
Name Status Preview Updated (UTC)
quri-ui ⬜️ Ignored (Inspect) Visit Preview Dec 23, 2024 8:39pm
squiggle-components ⬜️ Ignored (Inspect) Visit Preview Dec 23, 2024 8:39pm
squiggle-website ⬜️ Ignored (Inspect) Visit Preview Dec 23, 2024 8:39pm

Base automatically changed from organize-repo to main December 21, 2024 18:14
@OAGr
Copy link
Contributor

OAGr commented Dec 21, 2024

In that deployed URL, I got an error, when I tried Publishing. I assume some of the issue is just the fact that this this test environment on Vercel isn't fully set up. (In which case it would be nice if you could fix that)

image

Related, I noticed that on this branch, my workflows don't seem to save. After I run them, the seem to work fine - but after I refresh the page, it doesn't load the history.

@OAGr
Copy link
Contributor

OAGr commented Dec 21, 2024

I feel like the terminology in this PR can be improved. Right now it seems confusing to me. We don't use the phrase "publish" elsewhere in SquiggleHub, so as a user I'd be confused as to what this is actually doing.

image

Change "Publish" to "Publish Model"

image

Add some text saying, "Save this as a model on Squiggle Hub"

Change "Publish Workflow" to "Save Model"
Change "Publish" to "Save"

(At very least, I think "Publish Workflow" is misleading, as it's the model you are publishing)

@berekuk
Copy link
Collaborator Author

berekuk commented Dec 23, 2024

In that deployed URL, I got an error, when I tried Publishing. I assume some of the issue is just the fact that this this test environment on Vercel isn't fully set up. (In which case it would be nice if you could fix that)

Strange, it's working fine for me. Does this happen every time you try?

@berekuk
Copy link
Collaborator Author

berekuk commented Dec 23, 2024

I feel like the terminology in this PR can be improved. Right now it seems confusing to me.

Fair, fixed

@OAGr OAGr merged commit f593bb8 into main Dec 23, 2024
6 checks passed
@OAGr OAGr deleted the publish-ai-model branch December 23, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants