-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next.js 15 for Hub #3452
Next.js 15 for Hub #3452
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
* This might cause issues in the future, if we decide to depend on some library that's ESM-only; I'm not sure how good esbuild is for bundling ESM dependencies. | ||
* | ||
* But, for now, it seems like it's working. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kudos for adding the comment.
That said, I imagine you don't need all the *
characters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"starred-block" is the default style in eslint, and in JSDoc, so lately I've been using it by default.
The main benefit is that it's auto-aligned by Prettier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, I looked into it, good to know. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to see --turbo get added, that's great. I don't see anything objectionable in the code.
Btw, I think this broke the worker setup for Squiggle AI. |
--turbo
is enabled by default inpnpm run dev
orturbo run dev
; builds are much fasterExtra attributes from the server: aria-activedescendant
JedWatson/react-select#5859This PR is made unrelated to #3450, but implemented on top of it, to simplify the merge. (I hoped #3450 would go in before I'm done with this).
So the right diff to review is this: https://github.com/quantified-uncertainty/squiggle/pull/3452/files/764ace42b2585ecfef93e5abdcaadd4b0068cf57..a53b6fbbbcb09cb1090e839f8d17d942a783817c
(most of it is awaits because of https://nextjs.org/blog/next-15#async-request-apis-breaking-change)