Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js 15 for Hub #3452

Merged
merged 18 commits into from
Nov 30, 2024
Merged

Next.js 15 for Hub #3452

merged 18 commits into from
Nov 30, 2024

Conversation

berekuk
Copy link
Collaborator

@berekuk berekuk commented Nov 25, 2024

  • --turbo is enabled by default in pnpm run dev or turbo run dev; builds are much faster
  • Relay transforms work; Worker from squiggle-lang works (took me a while to find the optimal configuration that's compatible both with Next 15 and storybook in components...)
  • I had to upgrade next-auth to v5 beta, because it's still not released, but it seems to work fine for email sign-ins; I'll have to check the github flow when we deploy this to production, and in the worse case we'll have to revert
  • there's a patch for react-select, described in react-select v5.8.0: Extra attributes from the server: aria-activedescendant JedWatson/react-select#5859

This PR is made unrelated to #3450, but implemented on top of it, to simplify the merge. (I hoped #3450 would go in before I'm done with this).

So the right diff to review is this: https://github.com/quantified-uncertainty/squiggle/pull/3452/files/764ace42b2585ecfef93e5abdcaadd4b0068cf57..a53b6fbbbcb09cb1090e839f8d17d942a783817c
(most of it is awaits because of https://nextjs.org/blog/next-15#async-request-apis-breaking-change)

@berekuk berekuk requested a review from OAGr as a code owner November 25, 2024 00:28
Copy link

changeset-bot bot commented Nov 25, 2024

⚠️ No Changeset found

Latest commit: f84baa1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Nov 25, 2024 0:49am
squiggle-website ✅ Ready (Inspect) Visit Preview Nov 25, 2024 0:49am
2 Skipped Deployments
Name Status Preview Updated (UTC)
quri-ui ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 0:49am
squiggle-components ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 0:49am

* This might cause issues in the future, if we decide to depend on some library that's ESM-only; I'm not sure how good esbuild is for bundling ESM dependencies.
*
* But, for now, it seems like it's working.
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos for adding the comment.

That said, I imagine you don't need all the * characters?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"starred-block" is the default style in eslint, and in JSDoc, so lately I've been using it by default.

The main benefit is that it's auto-aligned by Prettier.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I looked into it, good to know. Thanks!

Copy link
Contributor

@OAGr OAGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see --turbo get added, that's great. I don't see anything objectionable in the code.

@OAGr OAGr merged commit 5fe7439 into main Nov 30, 2024
6 checks passed
@OAGr OAGr deleted the next-15 branch November 30, 2024 22:09
@OAGr
Copy link
Contributor

OAGr commented Dec 3, 2024

Btw, I think this broke the worker setup for Squiggle AI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants