Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ai Style Improvements #3424

Merged
merged 9 commits into from
Nov 6, 2024
Merged

Ai Style Improvements #3424

merged 9 commits into from
Nov 6, 2024

Conversation

OAGr
Copy link
Contributor

@OAGr OAGr commented Nov 6, 2024

No description provided.

@OAGr OAGr requested a review from berekuk as a code owner November 6, 2024 20:11
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Nov 6, 2024 9:13pm
squiggle-website ✅ Ready (Inspect) Visit Preview Nov 6, 2024 9:13pm
2 Skipped Deployments
Name Status Preview Updated (UTC)
quri-ui ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 9:13pm
squiggle-components ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 9:13pm

Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: 2d05a1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OAGr
Copy link
Contributor Author

OAGr commented Nov 6, 2024

Going to merge for a demo soon

@OAGr OAGr merged commit 0a7d808 into main Nov 6, 2024
6 checks passed
@OAGr OAGr deleted the ai-fixes branch November 6, 2024 22:12
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which version of pnpm do you use?

This diff starts with:

-lockfileVersion: '9.0'
+lockfileVersion: '6.0'

pnpm i in the current main reverts it back to 9.0 lockfile, I didn't think that the current pnpm is capable of generating that old version.

And then there's a bunch of other changes and sometimes downgrades which concern me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants