-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SquiggleOutputViewer refactorings and empty results #2984
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, will have a better idea when I start using it. Want to merge soon to minimize conflicts.
This PR is mostly refactorings (it splits out
ViewerBody
andViewerMenu
fromSquiggleOutputViewer
).I wanted to add some debugging views to the viewer, but got distracted by cleanups.
It includes two small user-facing changes:
code === ""
on the components side, but an empty program with a comment still failed; now empty programs are allowed in Peggy grammarVoidWidget
; now empty result page doesn't look broken:Another internal change is that
SqDict
now exposesisEmpty()
andsize()
. I couldn't resist removinggetResultVariables
and so on, they looked too trivial and copy-pasted to me; so I replaced them with direct lookups onSqOutput
.