Danger.location() function #2968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3919192 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* main: (101 commits) First parts of CR Refactored ViewerProvider to be back in SquiggleViewer Refactored RootProvider to be top-level Fix for mode title Attempt at better API of SquiggleChart First pass at Squiggle Viewer refactor Adds VDict safeGet method Fixed scrollEditorToPath not firing issue move focusOnPath to ItemStore no need for custom `key` refactor auto-focus zoomed in values Adds changeset Focus->Zoom In Formatted CSS Fixed weird focus for website, without important Fixed styles Responded to other comments Addressed most code parts of CR Update packages/components/src/components/SquiggleViewer/SqViewNode.tsx Made/use/store ValueWithContextViewerHandle refactor ...
|
Can we close this? I assume the tag does the main thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by @mlao-pdx in this thread.
After adding this, I also realized that it would give the location of
location()call, not of a value.So maybe we should add
Tag.locationtoo? Then@locationdecorator would return the entire range of the definition, that's a bit more precise.