Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken TextTooltip from value menu icon #2953

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

berekuk
Copy link
Collaborator

@berekuk berekuk commented Jan 10, 2024

In <SquiggleValueMenu>, we had a tooltip that said "Settings", but it was broken for a while because <Dropdown> doesn't forwardRef. This caused annoying warnings in dev console.

The tooltip wasn't not very useful, so I just removed it for now.

Screenshot 2024-01-10 at 13 43 06

@berekuk berekuk requested a review from OAGr as a code owner January 10, 2024 19:44
Copy link

changeset-bot bot commented Jan 10, 2024

⚠️ No Changeset found

Latest commit: 0fa91af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package "@quri/squiggle-components" depends on the ignored package "@quri/configs", but "@quri/squiggle-components" is not being ignored. Please add "@quri/squiggle-components" to the `ignore` option.
The package "@quri/prettier-plugin-squiggle" depends on the ignored package "@quri/configs", but "@quri/prettier-plugin-squiggle" is not being ignored. Please add "@quri/prettier-plugin-squiggle" to the `ignore` option.
The package "@quri/squiggle-lang" depends on the ignored package "@quri/configs", but "@quri/squiggle-lang" is not being ignored. Please add "@quri/squiggle-lang" to the `ignore` option.
The package "@quri/ui" depends on the ignored package "@quri/configs", but "@quri/ui" is not being ignored. Please add "@quri/ui" to the `ignore` option.
The package "@quri/versioned-squiggle-components" depends on the ignored package "@quri/configs", but "@quri/versioned-squiggle-components" is not being ignored. Please add "@quri/versioned-squiggle-components" to the `ignore` option.
The package "vscode-squiggle" depends on the ignored package "@quri/configs", but "vscode-squiggle" is not being ignored. Please add "vscode-squiggle" to the `ignore` option.

Copy link

vercel bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Jan 10, 2024 7:50pm
quri-ui ✅ Ready (Inspect) Visit Preview Jan 10, 2024 7:50pm
squiggle-components ✅ Ready (Inspect) Visit Preview Jan 10, 2024 7:50pm
squiggle-website ✅ Ready (Inspect) Visit Preview Jan 10, 2024 7:50pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant