-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed RV Plot #2927
Fixed RV Plot #2927
Conversation
🦋 Changeset detectedLatest commit: ceb2869 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Apply Sweep Rules to your PR?
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2927 +/- ##
==========================================
- Coverage 70.59% 69.78% -0.81%
==========================================
Files 119 119
Lines 6760 6762 +2
Branches 1442 1443 +1
==========================================
- Hits 4772 4719 -53
- Misses 1980 2035 +55
Partials 8 8 ☔ View full report in Codecov by Sentry. |
@@ -63,16 +63,20 @@ const Cell: FC<{ | |||
return <ErrorCell />; | |||
} | |||
const jsItem = itemResult.value.asJS(); | |||
if (!(jsItem instanceof Map)) { | |||
if (!(jsItem instanceof Object)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many things in JS are instanceof
Object:
> class X {}; (new X()) instanceof Object
true
> [] instanceof Object
true
OTOH, you do try/catch below, and rvSchema.parse
is still there, so it should be fine.
Hopefully fixed Hub RV plot too, but not sure.
Closes #2833