More docs automation #2923
More docs automation #2923
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
Apply Sweep Rules to your PR?
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2923 +/- ##
==========================================
+ Coverage 69.78% 69.84% +0.05%
==========================================
Files 119 120 +1
Lines 6762 6765 +3
Branches 1443 1444 +1
==========================================
+ Hits 4719 4725 +6
+ Misses 2035 2032 -3
Partials 8 8 ☔ View full report in Codecov by Sentry. |
| @@ -16,6 +16,7 @@ export type CodeEditorProps = { | |||
| lineWrapping?: boolean; | |||
| errors?: SqError[]; | |||
| sourceId?: string; | |||
| fontSize?: number; | |||
There was a problem hiding this comment.
I think size?: "normal" | "small", like we use in other components, would be better (editor size is not just about its font size, and I'm not even sure that modifying font size on top level makes sense), but nbd for now.
packages/components/src/stories/SquiggleChart/DistributionSizes.stories.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This is getting too complicated for me to review properly, and I trust that you checked it manually for corner cases.
One comment, though: ideally, height passed from the outside should be the height of the main frame, right?
But it can be a bit hard to do because useCanvas needs fixed height to initialize context, and drawAxes can increase the suggested padding (I don't think that happens often with the vertital padding, though).
So one idea for future improvements is to precalculate the height, based on inner height + necessary vertical padding for samples+title+axes in advance, maybe with the invisible canvas if we need to measure text size, and then use that in useCanvas call.
| const showAxisTitles = height > 30; | ||
| const shownXAxisTitle = showAxisTitles && !!plot.xScale.title; | ||
| const showXAxis = height > 15; | ||
| const nonTitleHeight = Math.max(height - (showXAxis ? 20 : 0), 0); |
There was a problem hiding this comment.
This line looks sketchy to me, not sure where 20 is coming from, probably the dependency on the internals of InnerDistributionsChart?
* main: fix result chart height Fixed RV Plot
This does a few small things:
interactiveExamples, which are likeexamples, but they get shown in theSquiggleEditor.SquiggleEditorto make it nicer to work in the documentation.BuiltInDocumentation toCommon, and pulls out some parts of it intoStringand the newBooleannamespace. (Note: We might want this to be calledBoolinstead)generateModulePagesnow also generates the_meta.jsonpage, which means that all of/Api/is now generated.