Replace hard-coded values in test cases with constants

[sweep-ai]

PR Feedback (click)

• 👍 Sweep Did Well
• 👎 Sweep Needs Improvement

I created this PR to address this rule:

"Avoid using magic numbers or hard-coded values in the code."

Description

This PR addresses the issue of hard-coded values in the test cases of the file "builtin_test.ts" in the "squiggle-lang" package. The hard-coded values were used in the comparison of arrays and this violated the rule of avoiding magic numbers or hard-coded values in the code.

To fix this issue, the hard-coded values have been replaced with variables or constants that have meaningful names. This makes the code more readable and maintainable.

Summary of Changes

• Defined constants for the arrays that are used in the test cases at the top of the "builtin_test.ts" file.
• Replaced the hard-coded array [1,2,3,5] in line 25 with the constant ARRAY_1235.
• Replaced the hard-coded array [1,2,3] in line 26 with the constant ARRAY_123 and the hard-coded array [1,2,3,5] with the constant ARRAY_1235.
• Replaced the hard-coded array [1,2,3,8] in line 27 with the constant ARRAY_1238 and the hard-coded array [1,2,3,5] with the constant ARRAY_1235.
• Ensured that the test cases still pass after these modifications.

Please review the changes and let me know if any further modifications are required.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
quri-hub	✅ Ready (Inspect)	Visit Preview	Jan 4, 2024 5:06am
quri-ui	✅ Ready (Inspect)	Visit Preview	Jan 4, 2024 5:06am
squiggle-components	✅ Ready (Inspect)	Visit Preview	Jan 4, 2024 5:06am
squiggle-website	✅ Ready (Inspect)	Visit Preview	Jan 4, 2024 5:06am

[sweep-ai]

Rollback Files For Sweep

• Rollback changes to packages/squiggle-lang/tests/library/builtin_test.ts
• Rollback changes to packages/squiggle-lang/tests/library/builtin_test.ts

[changeset-bot]

⚠️ No Changeset found

Latest commit: 64772b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR