-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing LLM generation, using JSON #2915
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Apply Sweep Rules to your PR?
|
Resolving merge conflicts: track the progress here.I'm currently resolving the merge conflicts in this PR. I will stack a new PR once I'm done.
An error has occurred: Cmd('git') failed due to: exit code(128) *** Please tell me who you are. Run git config --global user.email "[email protected]" to set your account's default identity. fatal: unable to auto-detect email address (got 'root@1b1e655815b6.(none)')' (tracking ID: b76f10354e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've converted the scripts to TS (and also fixed turbo misconfiguration).
const documentationFiles = await glob( | ||
"./src/pages/docs/{Api,Guides}/*.{md,mdx}" | ||
"./src/pages/docs/{Guides}/*.{md,mdx}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all API files in templates yet? I thought there's some stuff that's still not converted, https://github.com/quantified-uncertainty/squiggle/tree/1ff759c7f7aa015dbe61d638676053fe140b5ebc/packages/website/src/pages/docs/Api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right - not everything it converted. However, it's not that much, and will mostly get converted soon anyway. Plus, this fix is better than how it was previously.
Many thanks! I had a really annoying time trying to do that myself. |
* main: Fixed isEqual for Squiggle Lists Addressed CR comments Update packages/website/templates.mjs Update packages/squiggle-lang/src/fr/danger.ts Fixed css formatting Fixed padding and background color issues with documentation in editor
The documentation for the LLM reads like this now:
We could definitely optimize further, but this fixes the main issue (almost all docs were lost from the recent changes, as text was taken away from the API files)