You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Avoid using magic numbers or hard-coded values in the code."
Description
This PR addresses the issue of magic numbers and hard-coded values in the file "packages/squiggle-lang/src/value/simpleValue.ts". All such instances have been replaced with named constants to improve code readability and maintainability.
Summary of Changes
Replaced hard-coded strings "vType", "Lambda", "toString", and "paramenterString" with named constants in the function removeLambdas.
Replaced hard-coded strings "vtype" and "Dict" with named constants in the function simpleValueFromValue.
Replaced hard-coded strings "vType", "Calculator", "fn", "inputs", "autorun", "description", "title", and "sampleCount" with named constants in the function simpleValueFromValue.
Replaced hard-coded strings "vType", "Plot", "type", "title", "distributions", "name", "distribution", "xScale", "yScale", "showSummary", "fn", "points", "distXScale", "xDist", "yDist", "ids", and "relativeValues" with named constants in the function simpleValueFromValue.
Replaced hard-coded strings "vType", "TableChart", "data", "columns", "fn", and "name" with named constants in the function simpleValueFromValue.
Replaced hard-coded strings "vType", "Scale", "type", "tickFormat", and "title" with named constants in the function simpleValueFromValue.
All constants have been defined at the top of the file "packages/squiggle-lang/src/value/simpleValue.ts".
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![sweep-ai[bot]](https://avatars.githubusercontent.com/in/307814?s=60&v=4){kind=small}
PR Feedback (click)
I created this PR to address this rule:
"Avoid using magic numbers or hard-coded values in the code."
Description
This PR addresses the issue of magic numbers and hard-coded values in the file "packages/squiggle-lang/src/value/simpleValue.ts". All such instances have been replaced with named constants to improve code readability and maintainability.
Summary of Changes
removeLambdas.simpleValueFromValue.simpleValueFromValue.simpleValueFromValue.simpleValueFromValue.simpleValueFromValue.All constants have been defined at the top of the file "packages/squiggle-lang/src/value/simpleValue.ts".