Tooltips for top-level variables

[berekuk]

This PR also includes:

• semantic tooltips for stdlib functions (doesn't show tooltips on normal in "normal string", etc.)
• remove support for void values (())
• AST cleanups (change names for nodes in Lezer to be similar to nodes in AST produced by Peggy)
• highlighting fix for variables named with keywords (if = 5 is valid Squiggle but wasn't highlighed correctly by Lezer)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 994ecad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
quri-hub	✅ Ready (Inspect)	Visit Preview	Jan 19, 2024 7:39pm
squiggle-components	✅ Ready (Inspect)	Visit Preview	Jan 19, 2024 7:39pm
squiggle-website	✅ Ready (Inspect)	Visit Preview	Jan 19, 2024 7:39pm

1 Ignored Deployment

Name	Status	Preview	Updated (UTC)
quri-ui	⬜️ Ignored (Inspect)	Visit Preview	Jan 19, 2024 7:39pm

[sweep-ai]

Apply Sweep Rules to your PR?

• Apply: All docstrings and comments should be up to date.
• Apply: Ensure that all variables and functions have descriptive names.
• Apply: Avoid using magic numbers or hard-coded values in the code.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5be13ee) 69.73% compared to head (ec3c210) 69.88%.
Report is 68 commits behind head on main.

❗ Current head ec3c210 differs from pull request most recent head 994ecad. Consider uploading reports for the commit 994ecad to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2776      +/-   ##
==========================================
+ Coverage   69.73%   69.88%   +0.14%     
==========================================
  Files         120      120              
  Lines        6791     6775      -16     
  Branches     1448     1444       -4     
==========================================
- Hits         4736     4735       -1     
+ Misses       2047     2032      -15     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[berekuk]

TODO (copy-pasted from Discord):

• collapsible nodes don't work in the tooltip because <ViewerProvider> is not configured
• need to pass settings from the playground, right now <CodeEditor> doesn't get settings and tooltips use defaultPlaygroundSettings
• scroll, margins; maybe hide summaries
• probably hide the gear icon

[OAGr]

Quick flag that it would be neat if this could work for imported variables. Like when someone types,

import "hub:ozzie/test" as hub

... you can hover over hub.

[OAGr]

This still doesn't capture the fact that items named the same would get shown the last value, which seems pretty bad.

I'd wait until we can fix that.

That said, I also think this should wait for my PR about dots in the gutter.
https://squiggle-components-5lius8sjo-quantified-uncertainty.vercel.app/?path=/story/squiggle-squiggleplayground--comments

That might also help with choosing which are the last value.

[berekuk]

This still doesn't capture the fact that items named the same would get shown the last value, which seems pretty bad.
image

Ok, I added an extra check that the value's location matches the variable name: 2c5b2e1

So the tooltip just won't show on names that are shadowed later.

It would be preferable to show the temporary value, but that's hard. Showing a special tooltip (see

squiggle/packages/components/src/components/CodeEditor/useTooltipsExtension.tsx

Line 175 in 2c5b2e1

// TODO - if we can prove that the variable was shadowed, show the tooltip pointing to the latest assignment.

) would be better but that that's extra UI work, and I would prefer to spend time adding warnings to squiggle-lang instead.

[OAGr]

*ephemeral