Adds simple POST endpoint at /runSquiggle, and adds open-api.json schema #2523

OAGr · 2023-11-12T04:45:52Z

This is pretty basic, but should be good enough for ChatGPT

changeset-bot · 2023-11-12T04:45:56Z

⚠️ No Changeset found

Latest commit: 5c1f624

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2023-11-12T04:46:01Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
quri-hub	✅ Ready (Inspect)	Visit Preview	Dec 31, 2023 6:10am
squiggle-components	✅ Ready (Inspect)	Visit Preview	Dec 31, 2023 6:10am
squiggle-website	✅ Ready (Inspect)	Visit Preview	Dec 31, 2023 6:10am

1 Ignored Deployment

Name	Status	Preview	Updated (UTC)
quri-ui	⬜️ Ignored (Inspect)	Visit Preview	Dec 31, 2023 6:10am

sweep-ai · 2023-11-12T04:46:56Z

Apply Sweep Rules to your PR?

Apply: All docstrings and comments should be up to date.
Apply: Ensure that all variables and functions have descriptive names.
Apply: Avoid using unnecessary separators or extra characters in code.
Apply: Use consistent indentation and spacing throughout the code.
Apply: Ensure that all code is properly formatted and follows the style guide.
Apply: Avoid using magic numbers or hard-coded values in the code.

OAGr · 2023-11-12T04:47:05Z

That said, I can't seem to get ChatGPT to actually run this yet. It feels like all functions are failing for me. I'll continue to try.

OAGr · 2023-11-12T18:04:25Z

This is meant to close #2521

OAGr · 2023-11-13T20:15:19Z

packages/hub/src/app/api/runSquiggle/route.ts

@@ -0,0 +1,43 @@
+import { runSquiggle } from "@/graphql/queries/runSquiggle";


todo: I assume I should make a helper here

OAGr · 2023-11-13T20:20:54Z

packages/hub/src/app/api/runSquiggle/route.ts

+import { runSquiggle } from "@/graphql/queries/runSquiggle";
+import { NextRequest, NextResponse } from "next/server";
+
+export function GET(request: NextRequest) {


todo: remove

OAGr · 2023-11-15T04:10:39Z

packages/hub/src/graphql/queries/runSquiggle.ts

@@ -21,6 +25,20 @@ export const squiggleValueToJSON = (value: SqValue) => {
      if (value instanceof Map) {
        return Object.fromEntries(value.entries());
      }
+      if (value instanceof SqLambda) {
+        return value.toString();
+      }


todo: Also do this for calculators, and if there are any other responses that have Lambdas

@description

* main: (533 commits) Hot fix for method scale remove import assertion Added back scale default constants Added changeset ScaleShift -> Method Added back defaults to SqScale First pass on refactoring Scale convert textmate-grammar to a public package; highlight squiggle code in markdown MarkdownViewer uses shiki instead of react-syntax-highlighter Finishing touches to Tag.doc Changing @description to @doc Fixes from CR fix version order; fix insertVersion script Fixed minor import error Refactored text size and color data to be in MarkdownViewer support decorators on exported vars Update packages/website/scripts/compileDocsForLLM.js Update tag.ts Final touches to LLMPrompt page support 0.9.0 in ModelExportPage ...

* serialization-test: Fixed some bugs that I'm surprised were ever there Merged with main Deleted unused file Minor refactors to SimpleValue Some simple JSON tests Moved JSON methods to Danger Cleaning up SimpleValue Fixed map issue Restructure to fix most tests Moving SimpleValue code Simplifying SimpleValue Fixed merge with main Experiment with adding serialization

codecov · 2023-12-31T05:26:07Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f70a2a) 70.15% compared to head (5c1f624) 70.17%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2523      +/-   ##
==========================================
+ Coverage   70.15%   70.17%   +0.02%     
==========================================
  Files         119      119              
  Lines        6748     6750       +2     
  Branches     1436     1436              
==========================================
+ Hits         4734     4737       +3     
+ Misses       2006     2005       -1     
  Partials        8        8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

OAGr · 2023-12-31T06:09:26Z

packages/hub/src/graphql/queries/runSquiggle.ts

-  const project = SqProject.create();
+  const env = {
+    sampleCount: 1000, // int
+    xyPointLength: 1000, // int


I could see making this configurable later

OAGr · 2024-01-01T04:57:28Z

I'm going to merge, so I can make sure it's working with ChatGPT. Happy to make changes later on.

Adds simple experimental POST endpoint

d46637e

OAGr temporarily deployed to Preview November 12, 2023 04:45 — with GitHub Actions Inactive

vercel bot deployed to Preview – squiggle-components November 12, 2023 04:46 View deployment

vercel bot deployed to Preview – squiggle-website November 12, 2023 04:46 View deployment

vercel bot deployed to Preview – quri-ui November 12, 2023 04:47 View deployment

vercel bot deployed to Preview – quri-hub November 12, 2023 04:50 View deployment

OAGr commented Nov 13, 2023

View reviewed changes

Don't show all of lambdas in API response

380b83b

OAGr temporarily deployed to Preview November 14, 2023 05:00 — with GitHub Actions Inactive

vercel bot deployed to Preview – quri-hub November 14, 2023 05:02 View deployment

Quick sampleSet data

967568a

OAGr temporarily deployed to Preview November 14, 2023 05:16 — with GitHub Actions Inactive

vercel bot deployed to Preview – quri-hub November 14, 2023 05:18 View deployment

OAGr commented Nov 15, 2023

View reviewed changes

Hide calculator fns from API

1c86c39

OAGr temporarily deployed to Preview November 17, 2023 01:38 — with GitHub Actions Inactive

vercel bot deployed to Preview – quri-hub November 17, 2023 01:40 View deployment

OAGr temporarily deployed to Preview December 31, 2023 02:32 — with GitHub Actions Inactive

OAGr temporarily deployed to Preview December 31, 2023 02:33 — with GitHub Actions Inactive

vercel bot deployed to Preview – quri-ui December 31, 2023 02:35 View deployment

OAGr changed the base branch from main to Focus-tag December 31, 2023 02:35

OAGr changed the base branch from Focus-tag to main December 31, 2023 02:35

vercel bot deployed to Preview – squiggle-components December 31, 2023 02:35 View deployment

vercel bot deployed to Preview – quri-hub December 31, 2023 02:38 View deployment

vercel bot deployed to Preview – squiggle-website December 31, 2023 02:39 View deployment

Simplifying code, adding schema

61ff33f

OAGr temporarily deployed to Preview December 31, 2023 05:07 — with GitHub Actions Inactive

vercel bot deployed to Preview – quri-hub December 31, 2023 05:09 View deployment

Minor fixes

300f6a3

OAGr temporarily deployed to Preview December 31, 2023 05:21 — with GitHub Actions Inactive

Removing select tests for now

0dd04ee

OAGr temporarily deployed to Preview December 31, 2023 05:24 — with GitHub Actions Inactive

vercel bot deployed to Preview – squiggle-components December 31, 2023 05:26 View deployment

vercel bot deployed to Preview – quri-hub December 31, 2023 05:29 View deployment

vercel bot deployed to Preview – squiggle-website December 31, 2023 05:30 View deployment

Catch all errors in runSquiggle, give 500 if server error

aefb449

OAGr temporarily deployed to Preview December 31, 2023 05:45 — with GitHub Actions Inactive

vercel bot deployed to Preview – quri-hub December 31, 2023 05:47 View deployment

Fixed SqValue

5c1f624

OAGr temporarily deployed to Preview December 31, 2023 06:05 — with GitHub Actions Inactive

vercel bot deployed to Preview – quri-hub December 31, 2023 06:08 View deployment

OAGr commented Dec 31, 2023

View reviewed changes

vercel bot deployed to Preview – squiggle-components December 31, 2023 06:09 View deployment

OAGr changed the title ~~Adds simple experimental POST endpoint~~ Adds simple POST endpoint at /runSquiggle, and adds open-api.json schema Dec 31, 2023

OAGr marked this pull request as ready for review December 31, 2023 06:10

OAGr requested a review from berekuk as a code owner December 31, 2023 06:10

vercel bot deployed to Preview – squiggle-website December 31, 2023 06:10 View deployment

OAGr merged commit 431ee43 into main Jan 1, 2024
9 checks passed

OAGr deleted the run-squiggle-post-endpoint branch January 1, 2024 04:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds simple POST endpoint at /runSquiggle, and adds open-api.json schema #2523

Adds simple POST endpoint at /runSquiggle, and adds open-api.json schema #2523

OAGr commented Nov 12, 2023 •

edited

Loading

changeset-bot bot commented Nov 12, 2023 •

edited

Loading

vercel bot commented Nov 12, 2023 •

edited

Loading

sweep-ai bot commented Nov 12, 2023

OAGr commented Nov 12, 2023

OAGr commented Nov 12, 2023

OAGr Nov 13, 2023

OAGr Nov 13, 2023

OAGr Nov 15, 2023

codecov bot commented Dec 31, 2023 •

edited

Loading

OAGr Dec 31, 2023

OAGr commented Jan 1, 2024

		@@ -0,0 +1,43 @@
		import { runSquiggle } from "@/graphql/queries/runSquiggle";

Adds simple POST endpoint at /runSquiggle, and adds open-api.json schema #2523

Adds simple POST endpoint at /runSquiggle, and adds open-api.json schema #2523

Conversation

OAGr commented Nov 12, 2023 • edited Loading

changeset-bot bot commented Nov 12, 2023 • edited Loading

⚠️ No Changeset found

vercel bot commented Nov 12, 2023 • edited Loading

sweep-ai bot commented Nov 12, 2023

Apply Sweep Rules to your PR?

OAGr commented Nov 12, 2023

OAGr commented Nov 12, 2023

OAGr Nov 13, 2023

Choose a reason for hiding this comment

OAGr Nov 13, 2023

Choose a reason for hiding this comment

OAGr Nov 15, 2023

Choose a reason for hiding this comment

codecov bot commented Dec 31, 2023 • edited Loading

Codecov Report

OAGr Dec 31, 2023

Choose a reason for hiding this comment

OAGr commented Jan 1, 2024

OAGr commented Nov 12, 2023 •

edited

Loading

changeset-bot bot commented Nov 12, 2023 •

edited

Loading

vercel bot commented Nov 12, 2023 •

edited

Loading

codecov bot commented Dec 31, 2023 •

edited

Loading