[Sweep Rules] Fix broken code quality and TypeScript style rules #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sweep-ai[bot]](https://avatars.githubusercontent.com/in/307814?s=60&v=4){kind=small}
Rollback Files For Sweep
|
Sandbox Executions
Run CONTRIBUTING.md through the sandbox.
Run packages/website/src/pages/docs/Internal/Processing-Confidence-Intervals.md through the sandbox. |
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Feedback (click)
I created this PR to address this rule:
"Avoid using unnecessary separators or extra characters in code."
Description
This PR addresses the broken code quality and TypeScript style rules in the repository. The changes include updates to the
CONTRIBUTING.mdfile to align with the desired code quality and TypeScript style guidelines. Additionally, theProcessing-Confidence-Intervals.mdfile is modified to fix a code issue related to calculating the standard deviation.Summary of Changes
CONTRIBUTING.mdto aim for at least 8/10 quality in/packages/squiggle-langand 7/10 quality in/packages/components.CONTRIBUTING.mdto preferconstoverletand never usevar.CONTRIBUTING.mdto use functional style and avoid classes whenever possible.CONTRIBUTING.mdto wrap object types inReadonlyor mark individual fields asreadonly.CONTRIBUTING.mdto use native ES modules instead of namespaces.anyusage guidelines inCONTRIBUTING.mdto avoid usinganyas much as possible.CONTRIBUTING.mdto always use===instead of==.CONTRIBUTING.mdto avoid using too many external libraries, especially insquiggle-lang.CONTRIBUTING.mdto prefer named exports over default exports for easier refactorings.CONTRIBUTING.mdto name files according to their main named exports and split code into many small files.Processing-Confidence-Intervals.mdby updating the calculation of the standard deviation.Please review and merge these changes to ensure adherence to the desired code quality and TypeScript style guidelines.