[Sweep Rules] Descriptive Names Required for Variables and Functions #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sweep-ai[bot]](https://avatars.githubusercontent.com/in/307814?s=60&v=4){kind=small}
Rollback Files For Sweep
|
Sandbox Executions
Run packages/squiggle-lang/src/fr/danger.ts through the sandbox.
Run packages/squiggle-lang/src/fr/danger.ts through the sandbox.
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Feedback (click)
I created this PR to address this rule:
"Ensure that all variables and functions have descriptive names."
Description
This PR addresses the issue of having non-descriptive names for variables and functions in the codebase. It includes renaming variables and functions in the following files:
packages/squiggle-lang/src/fr/danger.tspackages/squiggle-lang/src/fr/list.tsThe changes aim to improve code readability and maintainability by using more descriptive names that accurately represent the purpose and functionality of the variables and functions.
Summary of Changes
In
packages/squiggle-lang/src/fr/danger.ts:REArgumentErrortoRuntimeArgumentError.combinationstogenerateCombinations.allCombinationstogenerateAllCombinations.In
packages/squiggle-lang/src/fr/list.ts:_assertIntegertovalidateInteger._assertValidArrayLengthtovalidateArrayLength.These changes improve the clarity and understandability of the codebase, making it easier to maintain and work with.