[Sweep Rules] Remove unnecessary separators or extra characters in code #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sweep-ai[bot]](https://avatars.githubusercontent.com/in/307814?s=60&v=4){kind=small}
Rollback Files For Sweep
|
Sandbox Executions
Run packages/squiggle-lang/__tests__/library/number_test.ts through the sandbox.
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2377 +/- ##
==========================================
+ Coverage 72.09% 72.10% +0.01%
==========================================
Files 111 111
Lines 5733 5733
Branches 1097 1097
==========================================
+ Hits 4133 4134 +1
+ Misses 1593 1592 -1
Partials 7 7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Feedback (click)
I created this PR to address this rule:
"Avoid using unnecessary separators or extra characters in code."
Description
This PR removes unnecessary separators or extra characters in the code to conform to the rule of avoiding them. The changes include removing the unnecessary
,separator after the last test case forNumber.sum([])in thepackages/squiggle-lang/__tests__/library/number_test.tsfile and removing the unnecessary,separator after the last argument of themakeNumberArrayToNumberDefinitionfunction and themakeNumberArrayToNumberArrayDefinitionfunction in thepackages/squiggle-lang/src/fr/number.tsfile.Summary of Changes
,separator after the last test case forNumber.sum([])inpackages/squiggle-lang/__tests__/library/number_test.ts.,separator after the last argument of themakeNumberArrayToNumberDefinitionfunction and themakeNumberArrayToNumberArrayDefinitionfunction inpackages/squiggle-lang/src/fr/number.ts.