You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds unit tests for the Date, Duration, and Number units in the Squiggle language. The tests cover the implementation of these units in the DateTime.ts file and ensure their correctness and functionality.
Summary of Changes
Created a new test file packages/squiggle-lang/__tests__/utility/DateTime_test.ts to test the Date, Duration, and Number units.
Imported the necessary modules from Jest for writing tests.
Imported the Duration, DateModule, and Date from packages/squiggle-lang/src/utility/DateTime.ts.
Wrote tests for each method and exported constant in the Duration object, covering typical use cases, boundary values, and invalid inputs.
Wrote tests for each method in the DateModule object, covering typical use cases, boundary values, and invalid inputs.
Wrote a test for the exported Date constant, verifying its value and type.
Testing
Ran the existing test suite to ensure that the new tests do not introduce any regressions.
Manually tested the Date, Duration, and Number units using various inputs and edge cases to verify their correctness.
Checklist
All existing tests pass.
New tests have been added to cover the Date, Duration, and Number units.
The code follows the established coding conventions and style guide.
Documentation has been updated to reflect the changes (if applicable).
The PR title and branch name are descriptive and follow the naming conventions.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Feedback: 👎
Description
This PR adds unit tests for the Date, Duration, and Number units in the Squiggle language. The tests cover the implementation of these units in the
DateTime.ts
file and ensure their correctness and functionality.Summary of Changes
packages/squiggle-lang/__tests__/utility/DateTime_test.ts
to test the Date, Duration, and Number units.Duration
,DateModule
, andDate
frompackages/squiggle-lang/src/utility/DateTime.ts
.Duration
object, covering typical use cases, boundary values, and invalid inputs.DateModule
object, covering typical use cases, boundary values, and invalid inputs.Date
constant, verifying its value and type.Testing
Checklist
Fixes #665.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can: