Fix formatting of long if/else chains #2369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sweep-ai[bot]](https://avatars.githubusercontent.com/in/307814?s=60&v=4){kind=small}
Sandbox Executions
Run packages/prettier-plugin/test/expressions.test.ts through the sandbox. |
Apply Sweep Rules to your PR?
|
|
5 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Feedback: 👎
Description
This PR addresses the issue with the formatting of long if/else chains in the Squiggle language. Currently, the Prettier plugin does not break if/else statements, leading to poorly formatted code when dealing with long if/else chains. This PR modifies the Prettier plugin to handle the formatting of long if/else chains, improving the readability of the code.
Summary of Changes
parser.tsfile in thepackages/prettier-plugin/src/directory to correctly identify and generate the Abstract Syntax Tree (AST) for long if/else chains.printer.tsfile in thepackages/prettier-plugin/src/directory to format long if/else chains by inserting line breaks between the if/else statements.expressions.test.tsfile in thepackages/prettier-plugin/test/directory to verify the correct formatting of long if/else chains.Please review and merge this PR to improve the formatting of long if/else chains in the Squiggle language.
Fixes #2332.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can: