Handle non-existent Relative Values pages #2364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sweep-ai[bot]](https://avatars.githubusercontent.com/in/307814?s=60&v=4){kind=small}
…ariableName]/page.tsx to packages/hub/src/app/models/[owner]/[slug]/relative-values/[variableName]/page.ts
…ariableName]/page.tsx
Sandbox Executions
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Apply Sweep Rules to your PR?
|
|
15 tasks
|
It's failing tests now. Try a different approach? |
🚀 Wrote ChangesDone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Feedback (click)
Description
This PR addresses the issue where accessing a non-existent Relative Values page on the Squiggle Hub platform results in a generic error message. The code has been modified to handle this case and provide a more informative error message or return a 404 error when a non-existent page is accessed.
Summary of Changes
packages/hub/src/app/models/[owner]/[slug]/relative-values/[variableName]/page.tsxfile.NotFoundErrorfrom thegraphql/errorsdirectory.NotFoundErrorwith a custom message if the data does not exist.NotFoundErrorin the component's error boundary to render a 404 page or a custom error message.Please review and merge this PR to resolve the issue with non-existent Relative Values pages.
Fixes #2360.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can: