You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes an issue with the color input for clusters in the Relative Values feature of the Squiggle application. Currently, the application does not accept capitalized hexadecimal color codes. This PR modifies the validation rule for the color field to accept both lowercase and uppercase hexadecimal characters.
Summary of Changes
Modified the regular expression in packages/hub/src/graphql/mutations/createRelativeValuesDefinition.ts to accept both lowercase and uppercase hexadecimal characters for the color input in clusters.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
I wasn't able to make changes. This could be due to an unclear request or a bug in my code.
As a reminder, comments on a file only modify that file. Comments on a PR (at the bottom of the "conversation" tab) can modify the entire PR. Please try again or contact us on Discord
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Feedback (click)
Description
This PR fixes an issue with the color input for clusters in the Relative Values feature of the Squiggle application. Currently, the application does not accept capitalized hexadecimal color codes. This PR modifies the validation rule for the color field to accept both lowercase and uppercase hexadecimal characters.
Summary of Changes
packages/hub/src/graphql/mutations/createRelativeValuesDefinition.ts
to accept both lowercase and uppercase hexadecimal characters for the color input in clusters.Fixes #2358.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can: