-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added sampleCount field to Calculator.make #2353
Conversation
🦋 Changeset detectedLatest commit: 1404987 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2353 +/- ##
==========================================
- Coverage 71.65% 71.61% -0.04%
==========================================
Files 111 111
Lines 5704 5707 +3
Branches 1091 1092 +1
==========================================
Hits 4087 4087
- Misses 1610 1613 +3
Partials 7 7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine but needs to be adapted to the latest calculators code.
Sorry, I forgot about this PR when I did my refactoring.
No worries, it's not very urgent. I'm curious how we can make |
I just replaced this with this other PR. Found it more straightforward to copy+paste the code and make changes. |
This adds a simple
sampleCount
to calculators, so that their sample count could be easily modified.We could trivially add
pointLength
, but I'm hesitant to encourage much use of that now.