Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sampleCount field to Calculator.make #2353

Closed
wants to merge 1 commit into from
Closed

Conversation

OAGr
Copy link
Contributor

@OAGr OAGr commented Oct 25, 2023

This adds a simple sampleCount to calculators, so that their sample count could be easily modified.

We could trivially add pointLength, but I'm hesitant to encourage much use of that now.

@OAGr OAGr requested a review from berekuk as a code owner October 25, 2023 23:53
@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2023

🦋 Changeset detected

Latest commit: 1404987

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@quri/squiggle-lang Patch
@quri/squiggle-components Patch
@quri/prettier-plugin-squiggle Patch
vscode-squiggle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@OAGr OAGr temporarily deployed to Preview October 25, 2023 23:53 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 11:58pm
quri-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 11:58pm
squiggle-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 11:58pm
squiggle-website ✅ Ready (Inspect) Visit Preview Oct 25, 2023 11:58pm

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (20b52b9) 71.65% compared to head (5c52606) 71.61%.
Report is 2 commits behind head on main.

❗ Current head 5c52606 differs from pull request most recent head 1404987. Consider uploading reports for the commit 1404987 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2353      +/-   ##
==========================================
- Coverage   71.65%   71.61%   -0.04%     
==========================================
  Files         111      111              
  Lines        5704     5707       +3     
  Branches     1091     1092       +1     
==========================================
  Hits         4087     4087              
- Misses       1610     1613       +3     
  Partials        7        7              

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@berekuk berekuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine but needs to be adapted to the latest calculators code.
Sorry, I forgot about this PR when I did my refactoring.

@OAGr
Copy link
Contributor Author

OAGr commented Nov 3, 2023

No worries, it's not very urgent. I'm curious how we can make sampleCount adjustable with the calculator inputs, but that's more work.

@OAGr
Copy link
Contributor Author

OAGr commented Nov 4, 2023

I just replaced this with this other PR. Found it more straightforward to copy+paste the code and make changes.
#2474

@OAGr OAGr closed this Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants