Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title to calculator and table, similar to plots #2341

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

OAGr
Copy link
Contributor

@OAGr OAGr commented Oct 18, 2023

No description provided.

@OAGr OAGr requested a review from berekuk as a code owner October 18, 2023 17:46
@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2023

⚠️ No Changeset found

Latest commit: f60b2c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OAGr OAGr temporarily deployed to Preview October 18, 2023 17:46 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 5:51pm
quri-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 5:51pm
squiggle-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 5:51pm
squiggle-website ✅ Ready (Inspect) Visit Preview Oct 18, 2023 5:51pm

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (de20836) 71.74% compared to head (bf00d56) 71.68%.
Report is 6 commits behind head on main.

❗ Current head bf00d56 differs from pull request most recent head f60b2c4. Consider uploading reports for the commit f60b2c4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2341      +/-   ##
==========================================
- Coverage   71.74%   71.68%   -0.06%     
==========================================
  Files         111      111              
  Lines        5688     5694       +6     
  Branches     1120     1088      -32     
==========================================
+ Hits         4081     4082       +1     
- Misses       1599     1605       +6     
+ Partials        8        7       -1     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@berekuk berekuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I haven't tried it in browser but diff looks straightforward and fine).

@OAGr OAGr merged commit 20b52b9 into main Oct 18, 2023
@OAGr OAGr deleted the add-title-to-calculator branch October 18, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants